search

NixOS / nixos-summer

Creative Commons Attribution Share Alike 4.0 International
9 stars 12 forks source link

Create blogpost 'callPackage, a tool for the lazy' #41

Closed NobbZ closed 2 years ago

NobbZ commented 2 years ago

Thank you for your thorough review. As it became quite huge I will give it another pass during lunchtime and apply a first set of suggestions.

NobbZ commented 2 years ago

There are now only 2 or 3 bigger comments left. I hope I will be able to tackle them during tomorrows lunch time…

NobbZ commented 2 years ago

I applied some changes yesterday evening, though due to the fact that I wasn't able to look at it for full 5 days, I lost track about which suggestions are still relevant.

Could one or both of you somehow highlight the relevant ones?

MMesch commented 2 years ago

I think only the one that talks about import statements etc is still relevant. Once we have found a solution for it we can bring this out!

NobbZ commented 2 years ago

@sbruder as @MMesch and @fricklerhandwerk have made a lot of suggestions I'd like to add them as co-authors in the blog post unless they refuse being mentioned :D

Is this possible with the current SSG? Or does it require changes on the templates/rendering?

sbruder commented 2 years ago

@NobbZ Currently, this is not possible. I added that functionality in https://github.com/NixOS/nixos-summer/pull/43.

NobbZ commented 2 years ago

Let me rebase after #43 has been merged and add you 2 as co authors

fricklerhandwerk commented 2 years ago

@MMesch merge is blocked on your approval.

MMesch commented 2 years ago

Will merge when I'm back on keyboard! Thanks all