search

NixOS / nixpkgs-vet

Tool to vet (check) Nixpkgs, including its pkgs/by-name directory
MIT License
31 stars 7 forks source link

nixpkgs-vet wants to move packages with uppercase names to pkgs/by-name #133

Closed pluiedev closed 8 hours ago

pluiedev commented 8 hours ago

Ditto (see https://github.com/NixOS/nixpkgs/actions/runs/12161429913/job/33916017215)

This issue is sort of similar to #107 and we really need to be more careful and only select packages that fit the naming criteria outlined by RFC 140:

Check the following using CI:

  • pkgs/by-name must only contain subdirectories of the form ${shard}/${name}, called package directories.
  • The name's of package directories must be unique when lowercased
  • name is a string only consisting of the ASCII characters a-z, A-Z, 0-9, - or _.
  • shard is the lowercased first two letters of name, expressed in Nix: shard = toLower (substring 0 2 name).
  • Each package directory must contain a package.nix file and may contain arbitrary other files.
pluiedev commented 8 hours ago

NVM, I misread the RFC 😓

infinisil commented 8 hours ago

Not sure I get what you mean, can you be more specific?

Edit: Ahh, only saw it being closed after I posted this :)