search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.99k stars 14.01k forks source link

haskell update infrastructure: clean up the update-stackage maintainer script #121510

Closed cdepillabout closed 3 years ago

cdepillabout commented 3 years ago

https://github.com/NixOS/nixpkgs/pull/121391 added some scripts that will be responsible for regenerating the Haskell package set from Hackage.

One of these scripts is maintainers/scripts/haskell/update-stackage.sh: https://github.com/NixOS/nixpkgs/blob/5d4dc79acbb98f935f55fec733c16c0d730cbdeb/maintainers/scripts/haskell/update-stackage.sh

This is responsible for updating the pinned packages from Stackage Nightly in the file pkgs/development/haskell-modules/configuration-hackage2nix.yaml.

One section of this script ignores the package versions from Stackage for a given set of packages:

https://github.com/NixOS/nixpkgs/blob/5d4dc79acbb98f935f55fec733c16c0d730cbdeb/maintainers/scripts/haskell/update-stackage.sh#L22-L41

This was useful when Nixpkgs used to track Stackage LTS, but no longer necessary since we now track Stackage Nightly.

Most packages should be removed from this section, except for Nixpkgs-specific packages (like jailbreak-cabal, distribution-nixpkgs, and cabal2nix).

Note that the above file is only currently on the haskell-updates branch. A PR fixing this should go to the haskell-updates branch.

dalpd commented 3 years ago

I believe this is addressed by https://github.com/NixOS/nixpkgs/commit/bf3a3b62e4a98d3b721ff222d7a457e3c013aaf5.