search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
16.75k stars 13.17k forks source link

Pijul is broken in every version - source repo disappeared #12924

Closed colemickens closed 8 years ago

colemickens commented 8 years ago

Here's the log: https://gist.github.com/9f04ad2893fe1ace2096

Looks like maybe the git tag was deleted? I'll try to send a PR to fix shortly and reach out to the Pijul folks about what happened.

colemickens commented 8 years ago 
mkdir temp; cd temp
darcs clone https://pijul.org
darcs show tags

They removed the 0.1 tag, it seems. Will send a PR to bump to 0.2.

ghost commented 8 years ago

Wait. I'm not sure what this means. We just released Pijul 0.2, which is a complete rewrite, with a totally unrelated darcs repository.

(btw while we're super happy to be in NixOS, none of the authors submitted Pijul, nor considered it ready at version 0.1).

colemickens commented 8 years ago

@pijul There is a definition for pijul 0.1 in nixpkgs right now.

It referenced the 0.1 tag in the darcs repo, which now no longer exists. This means pijul is currently broken for anyone who didn't install it before you changed repos.

I'm working on a fix to move to 0.2 but it looks like maybe the output directory structure has changed, so I need to wait for my rebuild to finish before I can send a PR.

ghost commented 8 years ago

Ok. The darcs repository http://pijul.org shares no patch with the previous one. Not only has the directory structure changed, even the programming language has changed.

We're now using Rust, and we do have a .nix file at the root of our repository. The github mirror has it too: https://github.com/pijul/pijul/blob/master/default.nix

colemickens commented 8 years ago

@pijul Can you please check in your Cargo.lock file? I can't add this to nixpkgs without it.

ghost commented 8 years ago

Done!

colemickens commented 8 years ago

I'm a bit impeded now because this is too strict and cd's to $src to look for the Cargo.lock.

vcunat commented 8 years ago

/cc maintainer @puffnfresh.

colemickens commented 8 years ago

The WIP is here: https://github.com/colemickens/nixpkgs/commit/03effaa946a2f1d9c5563f7cb7caf482b9b6ab1b

Still suspect problem is here: https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/rust/fetch-cargo-deps#L24

puffnfresh commented 8 years ago

@colemickens can we parameterise fetch-cargo-deps with a buildDir or something?

colemickens commented 8 years ago

Hm, it looks like fetch-cargo-deps already takes $src as a parameter src=$(realpath $1). Maybe my suspicion is wrong?

puffnfresh commented 8 years ago

@vcunat @colemickens @pijul I have it working and packaged in #13027.

colemickens commented 8 years ago

This was fixed in #13027. Thanks @puffnfresh.