NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.39k stars 14.34k forks source link

virt-manager: Missing toolbar icons #130034

Open mz-pdm opened 3 years ago

mz-pdm commented 3 years ago

Describe the bug The toolbar buttons for running, stopping, etc. VMs don't have their normal icons, just some default replacements.

To Reproduce Steps to reproduce the behavior:

  1. Start virt-manager.
  2. Look at its toolbar.

Expected behavior All the virt-manager toolbar buttons have their usual icons.

Screenshots toolbar screenshot

Notify maintainers @qknight @offline @fpletz @globin

Metadata

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:
jtojnar commented 3 years ago

Do you have some icon theme installed? We leave the icon set choice up to user. See #43150 for more info.

mz-pdm commented 3 years ago

Yes, I have hicolor-icon-theme-0.17 and adwaita-icon-theme-40.1.1. I tried to set xdg.icons.enable = true and it didn't help. virt-manager is the only application so far missing (some) toolbar icons.

John-Rodriguez-Git commented 3 years ago

Works for me: 2021-07-13_22-15

mz-pdm commented 3 years ago

Now the question is what's different in your environment. I have KDE:

  services.xserver.displayManager.sddm.enable = true;
  services.xserver.desktopManager.plasma5.enable = true;

Does it work for anybody with KDE?

John-Rodriguez-Git commented 3 years ago

I have KDE and cinnamon. I tried it with KDE this time: Screenshot_20210714_224948

virtualisation.libvirtd.enable = true;
users.mutableUsers = true;            
sound.enable = true;
networking.networkmanager.enable = true;
      services.flatpak.enable = true;
programs.fish.enable = true;
programs.firejail = {
enable = true;
wrappedBinaries = {
firefox = {
    executable = "${lib.getBin pkgs.firefox}/bin/firefox";
    profile = "${pkgs.firejail}/etc/firejail/firefox.profile";
  };
  mpv = {
    executable = "${lib.getBin pkgs.mpv}/bin/mpv";
    profile = "${pkgs.firejail}/etc/firejail/mpv.profile";
  };
};
};

  # networking.hostName = "nixos"; # Define your hostname.
  # networking.wireless.enable = true;  # Enables wireless support via wpa_supplicant.

  # The global useDHCP flag is deprecated, therefore explicitly set to false here.
  # Per-interface useDHCP will be mandatory in the future, so this generated config
  # replicates the default behaviour.
  networking.useDHCP = false;
  networking.interfaces.enp3s0.useDHCP = true;

  # Configure network proxy if necessary
  # networking.proxy.default = "http://user:password@proxy:port/";
  # networking.proxy.noProxy = "127.0.0.1,localhost,internal.domain";

  # Select internationalisation properties.
  # i18n.defaultLocale = "en_US.UTF-8";
  # console = {
  #   font = "Lat2-Terminus16";
  #   keyMap = "us";
  # };

  # Enable the X11 windowing system.
  services.xserver.enable = true;
services.cinnamon.apps.enable = true;
services.xserver.desktopManager.cinnamon.enable = true;

  # Enable the Plasma 5 Desktop Environment.
  services.xserver.displayManager.sddm.enable = true;
  services.xserver.desktopManager.plasma5.enable = true;

  # Configure keymap in X11
  services.xserver.layout = 
mz-pdm commented 3 years ago

Thank you. After adding

services.cinnamon.apps.enable = true;
services.xserver.desktopManager.cinnamon.enable = true;

to my configuration, virt-manager got its icons. I could see that the options above installed some additional icon themes. It seems humanity-icon-theme is the right one that contains all the icons needed by virt-manager.

So is some dependency missing in virt-manager?

stale[bot] commented 2 years ago

I marked this as stale due to inactivity. → More info