Nextcloud Theming Favicon Resets when nextcloud-update-plugins

sovereigndigitool commented 3 years ago

Describe the bug

A custom favicon set in Nextcloud Admin > Settings > Administration > Theming resets itself regularly. My theory is that this occurs every time a plugin is updated through the nextcloud-update-plugins.service. Interestingly, the favicon is only reset to the default favicon on the landing page, as soon as you log in the custom favicon is displayed.

Steps To Reproduce

Steps to reproduce the behavior:

Install Nextcloud Module
Set up custom favicon in theming
Wait until it is reset to the default favicon automatically

Expected behavior

A custom favicon should stay the favicon on all pages constantly.

Additional context

When the problem occurs, on the landing page the browser developer tools shows this HTML

<link rel="icon" href="/core/img/favicon.ico">

When logging in it shows this HTML

<link rel="icon" href="/apps/theming/favicon/settings?v=28">

When again setting up the favicon in Settings, on the landing page it shows this HTML

<link rel="icon" href="/apps/theming/favicon?v=30">

Until it resets automatically again. This cycle continues...

Notify maintainers

Ma27 commented 2 years ago

Cannot reproduce, at least it doesn't reset when running nextcloud-update-plugins.service. Also, "Wait until X" isn't really helpful when having to reproduce something :)

It would be helpful to know which version of Nextcloud and which apps you're using. Also, are there any helpful logs? And would you mind sharing your config?

I'm also not really sure if that's an actual distro bug. Have you checked if there are similar issues reported in the upstream issue-tracker?

sovereigndigitool commented 2 years ago

Cannot reproduce, at least it doesn't reset when running nextcloud-update-plugins.service. Also, "Wait until X" isn't really helpful when having to reproduce something :)

Hmm, I should have been more clear. You have to wait until an app update is executed through nextcloud-update-plugins.service. For this you have to wait until an app becomes outdated, no?

It would be helpful to know which version of Nextcloud and which apps you're using. Also, are there any helpful logs? And would you mind sharing your config?

Enabled:
  - activity: 2.15.0
  - calendar: 2.3.3
  - cloud_federation_api: 1.4.0
  - comments: 1.11.0
  - contacts: 4.0.2
  - dav: 1.18.0
  - federatedfilesharing: 1.11.0
  - files: 1.16.0
  - files_pdfviewer: 2.3.0
  - files_rightclick: 1.1.0
  - files_sharing: 1.13.2
  - files_trashbin: 1.11.0
  - files_versions: 1.14.0
  - logreader: 2.7.0
  - lookup_server_connector: 1.9.0
  - notifications: 2.10.1
  - oauth2: 1.9.0
  - photos: 1.4.0
  - privacy: 1.6.0
  - provisioning_api: 1.11.0
  - recommendations: 1.1.0
  - richdocuments: 4.2.2
  - serverinfo: 1.12.0
  - settings: 1.3.0
  - text: 3.3.0
  - theming: 1.12.0
  - twofactor_backupcodes: 1.10.1
  - twofactor_totp: 6.1.0
  - twofactor_u2f: 6.2.0
  - viewer: 1.6.0
  - workflowengine: 2.3.1
Disabled:
  - accessibility
  - admin_audit
  - circles
  - contactsinteraction
  - dashboard
  - deck
  - encryption
  - federation
  - files_external
  - files_videoplayer
  - firstrunwizard
  - nextcloud_announcements
  - password_policy
  - richdocumentscode
  - sharebymail
  - support
  - survey_client
  - systemtags
  - tasks
  - updatenotification
  - user_ldap
  - user_status
  - weather_status

{
    "system": {
        "apps_paths": [
            {
                "path": "\/var\/lib\/nextcloud\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/lib\/nextcloud\/store-apps",
                "url": "\/store-apps",
                "writable": true
            }
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "skeletondirectory": "",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 6379
        },
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "simpleSignUpLink.shown": false,
        "lost_password_link": "disabled",
        "log_type": "syslog",
        "log_level": "2",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "pgsql",
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "version": "22.1.1.2",
        "overwrite.cli.url": "http:\/\/localhost",
        "dbport": "",
        "dbtableprefix": "oc_",
        "installed": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "twofactor_enforced": "true",
        "twofactor_enforced_groups": [
            "XX",
            "XX"
        ],
        "twofactor_enforced_excluded_groups": [],
        "memcache.local": "\\OC\\Memcache\\APCu",
        "loglevel": 2,
        "maintenance": false,
        "mail_smtpmode": "smtp",
        "mail_smtpsecure": "ssl",
        "mail_sendmailmode": "smtp",
        "default_phone_region": "XX",
        "trashbin_retention_obligation": "auto, 30",
        "trusted_domains": [
            "cloud.example.com",
            "www.cloud.example.com"
        ]
    }
}

I'll attach logs as soon as this issue occurs again.

I'm also not really sure if that's an actual distro bug. Have you checked if there are similar issues reported in the upstream issue-tracker?

Couldn't find anything similar upstream.

I disabled autoUpdateApps and will see if this issue also occurs on manual app updates.

stale[bot] commented 2 years ago

I marked this as stale due to inactivity. → More info

NixOS / nixpkgs