Closed pseudocubic closed 3 years ago
pseudocubic
commented
3 years ago If I set my channel back to before ecf4ca4c2363373009f875732c832fe8d00f16b0 I am able to successfully install vscode:
NIXPKGS_ALLOW_UNFREE=1 NIX_PATH='nixpkgs=https://github.com/NixOS/nixpkgs/archive/268c8d77ca7302dd8c72370532e5158a0a3e4a2e.tar.gz' nix-shell -p vscode
prusnak
commented
3 years ago If I set my channel back to before ecf4ca4 I am able to successfully install vscode:
This commit comes from https://github.com/NixOS/nixpkgs/pull/137912 // cc @pshirshov @SuperSandro2000
SuperSandro2000
commented
3 years ago The path resources/app/node_modules.asar does not exist. This is pretty easy to filter out of the error message but why it is missing is the million dollar question.
To fix that build with -K and inspect the output where the directory is that it is searching for. I will try to take a look at this later.
Artturin
commented
3 years ago probably something to do with darwin
SuperSandro2000
commented
3 years ago I didn't even look at that yet. Builds fine on Linux, for Darwin I no longer want to invest time. If you find a solution feel free to submit a PR. Maybe it is already enough to gate this part of the code behind a lib.optionalString stdenv.isLinux?
happysalada
commented
3 years ago Just wondering if that new PR fixes your bug https://github.com/NixOS/nixpkgs/pull/139041
onethirtyfive
commented
3 years ago Just wondering if that new PR fixes your bug #139041
I've been lurking because I ran into the same failure. Unfortunately, no dice. Given this expression, part of my dotfiles:
{ pkgs, ... }:
let
pinnedPkgs = import (builtins.fetchGit {
name = "custom-vscode-1.60.2";
url = "https://github.com/samuela/nixpkgs/";
ref = "refs/heads/upkeep-bot/vscode-1.60.2-1632356161";
rev = "a946fb970f985e20d038e9d12c0db68a8b3b2f19";
}) {};
extensions = (with pinnedPkgs.vscode-extensions; [
bbenoist.nix
vscodevim.vim
] ++ pkgs.vscode-utils.extensionsFromVscodeMarketplace [{
name = "nix-env-selector";
publisher = "arrterian";
version = "1.0.7";
sha256 = "0mralimyzhyp4x9q98x3ck64ifbjqdp8cxcami7clvdvkmf8hxhf";
}]);
in pinnedPkgs.vscode-with-extensions.override {
vscodeExtensions = extensions;
}I get the same build failure:
building '/nix/store/x9j6la0656ly0s3gvigaak9281s5acny-vscode-1.60.2.drv'...
unpacking sources
unpacking source archive /nix/store/99a06l7vgp4qi4yxsspd4m1zr6wf313y-VSCode_1.60.2_darwin-arm64.zip
source root is Visual Studio Code.app
setting SOURCE_DATE_EPOCH to timestamp 1632314212 of file Visual
patching sources
internal/fs/utils.js:314
throw err;
^
Error: ENOENT: no such file or directory, open 'resources/app/node_modules.asar'
at Object.openSync (fs.js:498:3)
at Object.module.exports.readArchiveHeaderSync (/nix/store/f7jhdvdaxf7xlbilgrybkni2mahp95b9-asar-3.1.0/lib/node_modules/asar/lib/disk.js:58:17)
at Object.module.exports.readFilesystemSync (/nix/store/f7jhdvdaxf7xlbilgrybkni2mahp95b9-asar-3.1.0/lib/node_modules/asar/lib/disk.js:84:25)
at Object.module.exports.extractAll (/nix/store/f7jhdvdaxf7xlbilgrybkni2mahp95b9-asar-3.1.0/lib/node_modules/asar/lib/asar.js:174:27)
at Command.<anonymous> (/nix/store/f7jhdvdaxf7xlbilgrybkni2mahp95b9-asar-3.1.0/lib/node_modules/asar/bin/asar.js:72:10)
at Command.listener [as _actionHandler] (/nix/store/f7jhdvdaxf7xlbilgrybkni2mahp95b9-asar-3.1.0/lib/node_modules/asar/node_modules/commander/index.js:413:31)
at Command._parseCommand (/nix/store/f7jhdvdaxf7xlbilgrybkni2mahp95b9-asar-3.1.0/lib/node_modules/asar/node_modules/commander/index.js:914:14)
at Command._dispatchSubcommand (/nix/store/f7jhdvdaxf7xlbilgrybkni2mahp95b9-asar-3.1.0/lib/node_modules/asar/node_modules/commander/index.js:865:18)
at Command._parseCommand (/nix/store/f7jhdvdaxf7xlbilgrybkni2mahp95b9-asar-3.1.0/lib/node_modules/asar/node_modules/commander/index.js:882:12)
at Command.parse (/nix/store/f7jhdvdaxf7xlbilgrybkni2mahp95b9-asar-3.1.0/lib/node_modules/asar/node_modules/commander/index.js:717:10) {
errno: -2,
syscall: 'open',
code: 'ENOENT',
path: 'resources/app/node_modules.asar'
}
builder for '/nix/store/x9j6la0656ly0s3gvigaak9281s5acny-vscode-1.60.2.drv' failed with exit code 1
cannot build derivation '/nix/store/igf3wbsnpfqgqaxdx1r01filw8sl10s4-vscode-with-extensions-1.60.2.drv': 1 dependencies couldn't be builtSystem context:
$ nix-shell -p nix-info --run "nix-info -m"
- system: `"aarch64-darwin"`
- host os: `Darwin 20.6.0, macOS 11.6`
- multi-user?: `no`
- sandbox: `no`
- version: `nix-env (Nix) 2.3.15`
- channels(onethirtyfive): `"nixpkgs-21.11pre317242.bc9b956714e"`
- nixpkgs: `/Users/onethirtyfive/.nix-defexpr/channels/nixpkgs`The postpatch should be made linux only Or investigate how the darwin src differs from the linux src and see if the same patches can be applied there
Describe the bug
Vscode fails to build during
patching sourcesstepError: ENOENT: no such file or directory, open 'resources/app/node_modules.asar'Steps To Reproduce
Steps to reproduce the behavior:
nix-shell -p vscodeornix-env -iA nixpkgs.vscodeExpected behavior
Vscode to install into environment
Screenshots
Additional context
ran
nix-channel --updatebefore attempting to installNotify maintainers
@eadwu @Synthetica9 @maxeaubrey
Metadata
Please run
nix-shell -p nix-info --run "nix-info -m"and paste the result.Maintainer information: