NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.05k stars 14.04k forks source link

21.11 Feature Freeze #140168

Closed nrdxp closed 2 years ago

nrdxp commented 3 years ago

It's that time again!

Let's clarify any blocking concerns for the 21.11 Release, which will be cut on the 26th of November.

Nix/nix-cli ecosystem: @edolstra @grahamc @nbp @Profpatsch Mobile: @samueldr Nixos Modules / internals : @Infinisil @Ericson2314 @alyssais
Nixos tests: @tfc Marketing: @garbas Docs: @ryantm Release: @tomberek

C: @matthewbauer Coq: @CohenCyril @gares @siraben @vbgl @Zimmi48 Emacs: @adisbladis Vim/Neovim: @jonringer @softinio @teto Erlang: @gleber @NixOS/beam Go: @kalbasit @Mic92 @zowoq Haskell: @NixOS/haskell @cdepillabout @sternenseemann @maralorn @expipiplus1 Python: @FRidh @jonringer
Perl: @stigtsp Php: @NixOS/php @aanderse @etu @globin @ma27 @talyz Ruby: @marsam Rust: @zowoq @Mic92 @andir @LnL7 Dhall: @Gabriel439 @ehmry R: @jbedo @bcdarwin

Darwin: @NixOS/darwin-maintainers @toonn

Bazel: @mboes Blockchains @mmahut @RaghavSood Podman: @NixOS/podman DockerTools: @roberth @utdemir Gnome: @jtojnar @NixOS/gnome Qt / KDE: @ttuegel @NixOS/qt-kde Cinnamon: @mkg20001 Pantheon: @NixOS/pantheon Postgres: @thoughtpolice

Everyone else: @NixOS/nixpkgs-committers @NixOS/release-engineers

No issue is too big or small, but let's remember that we are all working on donated time here, so let's triage those issues that can be realistically addressed by release time. Thanks everyone!

tomberek commented 3 years ago

@domenkozar : I can devote time this week, but like you I would only be looking at the org repo without access. Let's all pair up this afternoon/evening?

toonn commented 3 years ago

@grahamc brought x86_64-darwin build capacity back up yesterday 🎉

mkg20001 commented 3 years ago

Any chance lxd support & image building stuff could get in before freeze? https://github.com/NixOS/nixpkgs/pull/120965

sternenseemann commented 2 years ago

144108 would be nice to squeeze in, but would need to know if there are any concerns upgrading the default GNAT version.

pennae commented 2 years ago

142765 fixes a regression in a module rewrite (and adds a section to the manual, since at least one user was quite confused by the change)

illustris commented 2 years ago

Can https://github.com/NixOS/nixpkgs/pull/144239 be merged in time for the release? This would make NixOS one of the easier ways of deploying and managing Hadoop clusters.

vs49688 commented 2 years ago

Can https://github.com/NixOS/nixpkgs/pull/144085 be looked at for this? It's a minor QoL change when using wine-staging.

spacefrogg commented 2 years ago

factor-lang is currently broken but not marked as such #136400, (fix PR #136921).

Synthetica9 commented 2 years ago

julia is an alias for julia 1.0.4, which is transitively unsafe by libgit2-0.27.10. As a consequence, nix-shell -p julia gives a warning and refuses to evaluate. Would like to see this changed, either by removing the dependency or updating the julia alias.

flokli commented 2 years ago

@Synthetica9 Unversioned attributes should always point to the latest release. We have it like this in various other places, too.

Users wanting to stick with Julia 1.0.4 could probably just use the julia_10 attribute. Can you open a PR doing that, and maybe update the release notes?

newAM commented 2 years ago

144960 is a small update to gnomeExtensions.dash-to-panel for gnome 41 compatibility, it would be nice to get this merged before the 21.11 release so that it works out of the box.

fabianhjr commented 2 years ago

Hey, could someone review or merge https://github.com/NixOS/nixpkgs/pull/138180 ?

It improves wayland on nvidia but there were some regression reports upstream for an intermediary version (1.1.8).

veprbl commented 2 years ago

Perhaps we could get #136641 in before release. It can cause regressions, though, so I'm trying to build test it right now.

prusnak commented 2 years ago

Let's get this in: https://github.com/NixOS/nixpkgs/pull/142016

jonringer commented 2 years ago

Just a reminder that branch off is at the end of the week. a release manager will try to ping any of the PRs to ensure there's some movement

vs49688 commented 2 years ago

Could I please get these in? They're just some additional packages. https://github.com/NixOS/nixpkgs/pull/144454 and https://github.com/NixOS/nixpkgs/pull/144449.

risicle commented 2 years ago

@vs49688 Backporting new packages to a stable release is allowed at any point in the release cycle (unless they affect any existing packages). There's no deadline for these.

mweinelt commented 2 years ago

I'd like to get https://github.com/NixOS/nixpkgs/pull/142319 in. Rebasing changes to node-packages.nix sparks no joy. That will eventually allow us to fix zigbee2mqtt to be compatible with recent home-assistant releases..

happysalada commented 2 years ago

a PR that updates the bash patches https://github.com/NixOS/nixpkgs/pull/146463 . One of those is a critical malloc bug fix. I would tend to merge this to master, but thought I should ask since this will trigger quite a lot of rebuilds. The PR itself was open a bit early and one of the mirror for the patch returns a 404, however if an evaluation is retriggered today, it should work no problem.

Thra11 commented 2 years ago

Pretty minor, but I'd like to get #145756 in before branch off.

jonringer commented 2 years ago

a PR that updates the bash patches #146463 . One of those is a critical malloc bug fix. I would tend to merge this to master, but thought I should ask since this will trigger quite a lot of rebuilds. The PR itself was open a bit early and one of the mirror for the patch returns a 404, however if an evaluation is retriggered today, it should work no problem.

IMO, this should be pushed to staging, and then backported. Adding it to staging-next will likely delay the release.

The critical malloc issue seems to only be present in some instances. If there's a critical CVE that has been identified, then I think it would warrant going directly into master, but I haven't seen that.

From https://lists.gnu.org/archive/html/bug-bash/2021-10/msg00055.html it's not clear if this an underlying issue with systemd or bash. Bash seems to be doing the proper, "I allocated this much for you, that's all you get". While systemd is like, "yes, but I can take up to this amount, because it's free real estate."

rnhmjoj commented 2 years ago

I know it's late, but it took me 10 days (thanks chromium) to properly test this: #146545

ju1m commented 2 years ago

~I'd like to get https://github.com/NixOS/nixpkgs/pull/146386 in. It makes hyperscan (a dependency of rspamd) build again. Thanks in advance.~ EDIT: thanks, it has been done.

jonringer commented 2 years ago

I know it's late, but it took me 10 days (thanks chromium) to properly test this: #146545

I'm fine with backporting it. Doesn't look like any breaking behavior changes

Mic92 commented 2 years ago

We might want to fix this btf issue when upgrading kernels https://github.com/NixOS/nixpkgs/issues/145249 and this issue with having systemd-logind restarting and crashing login sessions: https://discourse.nixos.org/t/nixos-rebuild-switch-crashes-wm-de/16127/4

sternenseemann commented 2 years ago

Reminder (to self) to backport these if they don't make it into the release before branch-off:

Moredread commented 2 years ago
balsoft commented 2 years ago

If it's still possible, I would request https://github.com/NixOS/nixpkgs/pull/146515 to be accepted

SuperSandro2000 commented 2 years ago

If it's still possible, I would request #146515 to be accepted

I don't think we should squeeze in such a change last minute. There are probably more packages which need some adjustment and having that change a few months in unstable will probably reveal most of them. Especially DEs which heavily rely on XDG* shoulnd't break.


Since it is a mass rebuild it needs to go to staging anyway which is to late for 21.11. This could be backported but due to the potential breaking changes I would argue we shouldn't do that.

vs49688 commented 2 years ago

Audacious 4.1 contains bug fixes that'd be nice to have in 21.11: https://github.com/NixOS/nixpkgs/pull/147247

YellowOnion commented 2 years ago

what about #144930 ? it's a testing kernel anyway and it doesn't really effect anything but itself.

vcunat commented 2 years ago

I don't follow you. That was merged days ago to master and thus got included in 21.11 automatically (fork happened just a couple days ago).

daijihong commented 2 years ago

it is the 26th of November now in China. waitting...

tomberek commented 2 years ago

We need help with https://github.com/NixOS/nixpkgs/issues/147294

cab404 commented 2 years ago

Need review of https://github.com/NixOS/nixpkgs/pull/147544

ehmry commented 2 years ago

Our Squeak (Smalltalk) VM is stale and incompatible with current Squeak images, I'd like to get a new one in this release #147478.

onny commented 2 years ago

Already updated my notebook to 21.11 and my home server soon :D Many new features and bugfixes!

daijihong commented 2 years ago

expect release :)

mkg20001 commented 2 years ago

@ehmry (and others): Generally everything that is not a breaking change can simply be backported. If it is a breaking change it can be introduced in a non-breaking manner (for example a breaking package updated could be introduced with a different name, as has been done with yggdrasil 4 in 21.05) without affecting the defaults.

For maintainers: just add the backport release-21.11 tag before merge and merge the PR the bot generates

Edit: In case it wasn't clear the release is cut, so everything that comes after the cut is a backport.

jonringer commented 2 years ago

Edit: In case it wasn't clear the release is cut, so everything that comes after the cut is a backport.

After branch-off this is true. Which was done a ~week ago

nixos-discourse commented 2 years ago

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/lets-have-a-great-21-11-release-cycle/15262/11

vcunat commented 2 years ago

@prehonor: this isn't a good thread for such reports. Use e.g. a separate issue.

vcunat commented 2 years ago

The release happened hours ago, so let me close. Of course, some of the mentioned topics might still qualify for 21.11 backports, etc.