Use the correct JAVA_HOME value

pmeiyu commented 3 years ago

We create a weird symlink ($out/lib/src.zip) in the jdk package. I guess that symlink is only needed if $JAVA_HOME is set to $pkgs.jdk rather than the correct $pkgs.jdk.home or $pkgs.jdk/lib/openjdk.

grep JAVA_HOME -r shows many JAVA_HOME variables in the nixpkgs repository are incorrectly set to $pkgs.jdk. Should we change these variables to $pkgs.jdk.home and delete $out/lib/src.zip from jdk package?

References:

What is correct location of src.zip file in JDK?
#95081 openjdk11: add src.zip for IDEs
#140257 openjdk17: init at 17.0.1+12

stale[bot] commented 2 years ago

I marked this as stale due to inactivity. → More info

tomodachi94 commented 2 weeks ago

If https://github.com/NixOS/nixpkgs/issues/23557 was fixed, we could simply change all --set JAVA_HOMEs to --set JAVA_HOME "$JAVA_HOME".

NixOS / nixpkgs

Use the correct JAVA_HOME value #142938