NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.29k stars 13.54k forks source link

Tracking issue: move unnecesary VM tests #143681

Open Synthetica9 opened 2 years ago

Synthetica9 commented 2 years ago

Issue description

There are some VM tests that don't actually use any of the VM's capabilities. These would be better suited as installation tests on the packages that they test

Upsides:

Affected tests

Possibly incomplete list, maintainers: feel free to edit this comment if you know of more.

Possible further steps

blitz commented 2 years ago

@Synthetica9 I've moved the spike nixos test to be an installCheck. See #143832.

roberth commented 2 years ago

[ ] Edit PR template

I would have made that the first step. See https://github.com/NixOS/nixpkgs/pull/144033

Adda0 commented 1 month ago

Handbrake test can be marked as finished, too, as per #143687.