NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.77k stars 13.88k forks source link

A call for Darwin maintainers #145230

Closed domenkozar closed 3 months ago

domenkozar commented 2 years ago

We'd really benefit from better coordination around fixing darwin/macOS packages.

We have darwin-maintainers team which is currently 7 members.

If you'd like to join the team, we're looking for help with the following:

You're welcome to join MacOS+Nix community at https://matrix.to/#/#macos:nixos.org

If you need access to M1 community box see https://github.com/winterqt/darwin-build-box

Feel free to nominate yourself and help use bring macOS into a better state :)

nixos-discourse commented 2 years ago

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/a-call-for-darwin-maintainers/15985/1

kloenk commented 2 years ago

I would like to nominate myself, as I'm using an m1 Mac. The macOS sdk is a bit above my knowledge, but I can try to help with other things.

I'm currently in University though, so I have to see how much time I have. But Pinging me could help to remember me to do nixpkgs things :-)

fiddlerwoaroof commented 2 years ago

Hi, I’m interested, but I’m not sure how much time I have. Is there any list of good first issues? I have both Intel and M1 hardware.

mstone commented 2 years ago

I’m also interested, at least for the current personal planning horizon.

domenkozar commented 2 years ago

Invited all three, thanks a lot for helping out :heart:

uri-canva commented 2 years ago

I have access to both x86_64-darwin and aarch64-darwin, happy to help!

mikroskeem commented 2 years ago

I have aarch64-darwin (and x86_64-darwin, via Rosetta), happy to help as well.

winterqt commented 2 years ago

Hi! I have access to an aarch64-darwin machine and would be happy to help.

prusnak commented 2 years ago

Please add me as well. I have aarch64-darwin (and x86_64-darwin, via Rosetta).

griff commented 2 years ago

I have a x86_64-darwin and though I am very busy at the moment I will try and timebox an hour a day for helping with this.

kevingriffin commented 2 years ago

I'd be happy to help with my aarch64-darwin, and probably an Intel one somewhere too.

thefloweringash commented 2 years ago

I'd like to help out where I can.

kira-bruneau commented 2 years ago

I have a x86_64-darwin machine, and I'd be happy to help out when I can :slightly_smiling_face:

jonringer commented 2 years ago

I would like to thank everyone who has volunteered, really helps.

I apologize ahead-of-time for spamming you all during ZHF :)

kubukoz commented 2 years ago

I have an x86_64 machine, M1 coming later in the month, happy to run checks but I don't know much about the underlying magic.

olebedev commented 2 years ago

I have x86_64 and M1 machines, I would be happy to help!

willjr commented 2 years ago

I'd also be happy to help! I'm both a NixOS and MacOS user!

samuela commented 2 years ago

Happy to help any way I can!

sikmir commented 2 years ago

I use both NixOS and MacOS (x86_64), I'd like to help.

smaret commented 2 years ago

I can help too.

groodt commented 2 years ago

I'm happy to help. I'm x86_64-darwin and hopefully aarch64-darwin sometime in the future.

domenkozar commented 2 years ago

We've grown the @NixOS/darwin-maintainers team from 7 members to 27 in the last 24h.

That's an overwhelming response.

Thank you all for helping out!

hexagonal-sun commented 2 years ago

Happy to help with aarch64-darwin. I also have an outstanding PR that aims to improve the Nix experience on darwin machines by creating /Applications launchers for packages (see #131891). Thanks!

starcraft66 commented 2 years ago

Hi! I have both x86_64-darwin and aarch64-darwin machines at my disposal and would be happy to help!

nixos-discourse commented 2 years ago

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-macos-monthly/12330/12

NilsIrl commented 2 years ago

Hi, I'd be interested.

marsam commented 2 years ago

Hi, I would be happy to help!

Artturin commented 2 years ago

Interested people please take a look at issues with the darwin label https://github.com/NixOS/nixpkgs/issues?q=is%3Aopen+label%3A%226.topic%3A+darwin%22+is%3Aissue+

and PRs https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen+label%3A%226.topic%3A+darwin%22

maljub01 commented 2 years ago

I have x86_64 and M1 machines, I would also be happy to help. I'll be taking a look through the list of issues and trying to fix them whenever I can.

mexisme commented 2 years ago

I'd also be happy to help! I'm both a NixOS and MacOS user!

I'd also be very happy to help, for the same reasons.

damien-biasotto commented 2 years ago

I would be happy to help, I have both M1 and Intel macOS platforms, and NixOS is my daily driver.

0x4A6F commented 2 years ago

I have access to neither aarch64-darwin nor x84_x64-darwin and other people in this situation could tag issues/pr with the appropriate tag or join #macos:nixos.org (matrix) and ask for assistance.

That helped me in at least one occasion. Thanks for working on Darwin. :heart:

reckenrode commented 2 years ago

Some of you may have seen a response from me last night. I took it down because I wanted to take some more time to reflect on it. I appreciate the work everyone does on getting and keeping Darwin working with Nix. It can be demoralizing sometimes to run into packages that should work but don’t, especially if fixing them is non-trivial. I’ve submitted a few PRs so far to fix broken things and plan to continue submitting more in the future as I work through the overlays in my flake. Anyway, I just wanted to say again how great the work people do on Darwin support is.

I have access to both x86_64 and aarch64 systems for both macOS and NixOS. I’d be happy to help and do what I can.

winterqt commented 2 years ago

Anyway, I just wanted to say again how great the work people do on Darwin support is.

@reckenrode Thank you for your work as well! (you might recognize me from the Home Manager application launcher issue, I'm still using your rsync snippet :)

domenkozar commented 2 years ago

We have 5 more macs (intel and arm) running at ofborg as of recently, so do use ofborg to test PRs!

I suspect a lot of darwin failures are because a new package was added, it was marked as unix compatible (based on upstream claim) but the package really never built for darwin. It's totally fine if we mark such packages as not supported on darwin. Once ZHF is over, I'd just mark the rest as broken.

In case you work at a company that uses macOS+Nix, I'd kindly ask you to request your company to donate to https://opencollective.com/nix-macos so that we can fix the remaining big blockers that drag down darwin.

Thank you all :heart:

flurie commented 2 years ago

I suspect a lot of darwin failures are because a new package was added, it was marked as unix compatible (based on upstream claim) but the package really never built for darwin.

These are pretty easy to spot. I've fixed a few of them so far. The good news is that the fixes are usually fairly obvious once one knows what to look for. The bad news is that sometimes these fixes must be done upstream.

ylh commented 2 years ago

Not sure if this is the place to ask, but I've been bitten in multiple different places by the fact that macOS SDK selection differs between aarch64 and x86_64 -- on the former, the fundamental build input is the command-line tools DMG, whereas on the latter, it's a bunch of opensource.apple.com packages. This is responsible for all sorts of cursed inconsistencies in building on both archs. Is the problem to do with waiting for a fresher open-source release from Apple to handle aarch64, or would we accept accepting the binary SDK as an input on both platforms? It's a tricky balance between expediency, consistency, and open-source purity, I suppose.

If there's some initiative to deal with this in particular, I'd love to be pointed to it and help.

Artturin commented 2 years ago

@ylh https://github.com/NixOS/nixpkgs/issues/116341

https://github.com/NixOS/nixpkgs/issues/101229

@toonn is being paid to work on nix on darwin https://opencollective.com/nix-macos Please contribute financially if you'd like to support the effort

Artturin commented 2 years ago

someone on aarch64-darwin please take a look https://github.com/NixOS/nixpkgs/pull/147376#issuecomment-981226882

yeongsheng-tan commented 2 years ago

I'd like to help. In an active user benefiting a lot from nix nixpkgs and flakes for building out our homogeneous development environment for x86_64-darwin and x86_64-linux and hopefully in the next 6 months to 1 year on aarch64-darwin. I have a macOS x86_64-darwin BigSur machine as my primary workhorse now which may be able to contribute to the cause.

domenkozar commented 2 years ago

@yeongsheng-tan invited!

cideM commented 2 years ago

I run NixOS and have an M1 Mac powered by Home Manager, would love to help

Steven0351 commented 2 years ago

I'm a little late to the party here and new to Nix, but I have both x86_64 (macbook pro) and aarch64 (mac mini) darwin machines and would like to help out.

CorbanR commented 2 years ago

I also have a new M1 Max Mac and would like to contribute back to nix!

ixnij commented 2 years ago

I'm using an M1 MacBook Pro with Nix and home-manager, I'd love to help.

domenkozar commented 2 years ago

Invited @cideM, @Steven0351, @CorbanR and @ixnij

nixos-discourse commented 2 years ago

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-macos-monthly/12330/14

joedevivo commented 2 years ago

I'd like to help as well

willcohen commented 2 years ago

Would love to be added too!

domenkozar commented 2 years ago

Invited :)