services.tor.settings.RejectPlaintextPorts broken with multiple ports - Githubissues

NixOS / nixpkgs

Nix Packages collection & NixOS

MIT License

17.59k stars 13.74k forks source link

services.tor.settings.RejectPlaintextPorts broken with multiple ports #146691

Open woffs opened 2 years ago

woffs commented 2 years ago

Issue description

RejectPlaintextPorts generates each port on an extra line in config, but manual says it should be one line:

RejectPlaintextPorts port,port,...

Steps to reproduce

services.tor.settings.RejectPlaintextPorts = [ 23 80 ];

leads to two lines in torrc

RejectPlaintextPorts 23
RejectPlaintextPorts 80

and the warning

[warn] Option 'RejectPlaintextPorts' used more than once; all but the last value will be ignored.

resulting in Port 23 not being rejected

Technical details

system: "x86_64-linux"
host os: Linux 5.10.79, NixOS, 21.05.4116.46251a79f75 (Okapi)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.16
channels(root): "nixos-21.05.4116.46251a79f75"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

ehmry commented 1 year ago

The typed configuration for services.tor.settings should just go away.