search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.16k stars 14.18k forks source link

Upgrade waybar from 0.9.8 to 0.9.9 #155256

Closed mhwombat closed 2 years ago

mhwombat commented 2 years ago
Checklist
Project name

nix search name: waybar

current version: 0.9.8 desired version: 0.9.9

Notify maintainers

maintainers: @FlorianFranzen @minijackson @Synthetica9 @lovesegfault

Note for maintainers

Please tag this issue in your PR.

I tried to be helpful and do this myself (so that I could create a pull request). In my fork of nixpkgs, I made the following change:

$ git diff
diff --git a/pkgs/applications/misc/waybar/default.nix b/pkgs/applications/misc/waybar/default.nix
index 38ea7c909c0..c25708c260e 100644
--- a/pkgs/applications/misc/waybar/default.nix
+++ b/pkgs/applications/misc/waybar/default.nix
@@ -29,13 +29,13 @@

 stdenv.mkDerivation rec {
   pname = "waybar";
-  version = "0.9.8";
+  version = "0.9.9";

   src = fetchFromGitHub {
     owner = "Alexays";
     repo = "Waybar";
     rev = version;
-    sha256 = "sha256-XOguhbvlO3iUyk5gWOvimipXV8yqnia0LKoSA1wiKoE=";
+    sha256 = "sha256-yXvT9NMXtUxr9VVLADoL6PUOMko5yFFc51zNsfHz6S4=";
   };

   nativeBuildInputs = [

However, when I try to build it I get an error:

$ sudo nixos-rebuild switch --upgrade -I nixpkgs=/home/amy/github/nixpkgs
[sudo] password for amy:
unpacking channels...
building Nix...
building the system configuration...
these 12 derivations will be built:
  /nix/store/yql2lhscvpkilyxhxh4kqg8w1zr3ymd5-waybar-0.9.9.drv
  /nix/store/h4xjj34m0s7x2aqdfr3108a4wfn6iyib-system-path.drv
  /nix/store/j8iqwf4g227js06diii70718sbbf32iz-dbus-1.drv
  /nix/store/4f5cfvwg17890i4vvy51r1f3gv6hig7r-unit-dbus.service.drv
  /nix/store/4gsj0cn7i8242lqb1809mlbgd71v0yqk-unit-dbus.service.drv
  /nix/store/n2sj4v2iqimbga9m7d35d93v072ahf0f-user-units.drv
  /nix/store/rypkmhsa90q481vwx7hm6i6ppc9lgi7x-unit-polkit.service.drv
  /nix/store/vcpkd6rb785jrzj5fag4avkjwma3kwb4-unit-systemd-fsck-.service.drv
  /nix/store/yfm26cikibrry8vxmmnvxkf2h7whvbdd-unit-accounts-daemon.service.drv
  /nix/store/vfagan6wwfcnrq2cd40ag1fwn73rxgq1-system-units.drv
  /nix/store/w7ijmgk1mzwqymnb9iw5vjalka124j8m-etc.drv
  /nix/store/6w5bscy91m6ycwpc9009k0y6pz3xniby-nixos-system-wombat11k-21.11.git.76f5b6bb9cfM.drv
building '/nix/store/yql2lhscvpkilyxhxh4kqg8w1zr3ymd5-waybar-0.9.9.drv'...
unpacking sources
unpacking source archive /nix/store/9c7sg836s7py8awjwsds6jhq91z432kv-source
source root is source
patching sources
configuring
meson flags: --buildtype=plain         --libdir=/nix/store/zibqhc1bsczwzbf8izrf1jkp0kj2wqg1-waybar-0.9.9/lib --libexecdir=/nix/store/zibqhc1bsczwzbf8izrf1jkp0kj2wqg1-waybar-0.9.9/libexec         --bindir=/nix/store/zibqhc1bsczwzbf8izrf1jkp0kj2wqg1-waybar-0.9.9/bin --sbindir=/nix/store/zibqhc1bsczwzbf8izrf1jkp0kj2wqg1-waybar-0.9.9/sbin         --includedir=/nix/store/zibqhc1bsczwzbf8izrf1jkp0kj2wqg1-waybar-0.9.9/include         --mandir=/nix/store/zibqhc1bsczwzbf8izrf1jkp0kj2wqg1-waybar-0.9.9/share/man --infodir=/nix/store/zibqhc1bsczwzbf8izrf1jkp0kj2wqg1-waybar-0.9.9/share/info         --localedir=/nix/store/zibqhc1bsczwzbf8izrf1jkp0kj2wqg1-waybar-0.9.9/share/locale         -Dauto_features=enabled         -Dwrap_mode=nodownload         --prefix=/nix/store/zibqhc1bsczwzbf8izrf1jkp0kj2wqg1-waybar-0.9.9 -Ddbusmenu-gtk=enabled -Dlibnl=enabled -Dlibudev=enabled -Dmpd=enabled -Dpulseaudio=enabled -Drfkill=enabled -Dsndio=enabled -Dsystemd=disabled -Dgtk-layer-shell=enabled -Dman-pages=enabled
The Meson build system
Version: 0.57.1
Source dir: /build/source
Build dir: /build/source/build
Build type: native build
Project name: waybar
Project version: 0.9.9
C compiler for the host machine: gcc (gcc 10.3.0 "gcc (GCC) 10.3.0")
C linker for the host machine: gcc ld.bfd 2.35.2
C++ compiler for the host machine: g++ (gcc 10.3.0 "g++ (GCC) 10.3.0")
C++ linker for the host machine: g++ ld.bfd 2.35.2
Host machine cpu family: x86_64
Host machine cpu: x86_64
Compiler for C++ supports link arguments -lc++fs: NO
Compiler for C++ supports link arguments -lc++experimental: NO
Compiler for C++ supports link arguments -lstdc++fs: YES
Program git found: NO
Has header "filesystem" : YES
Checking if "nl_langinfo with _NL_TIME_WEEK_1STDAY, _NL_TIME_FIRST_WEEKDAY" links: YES
Run-time dependency threads found: YES
Found pkg-config: /nix/store/0pymd6cd7kaj6lrxgcficbd232zrpdi3-pkg-config-wrapper-0.29.2/bin/pkg-config (0.29.2)
Run-time dependency fmt found: YES 8.0.1
Run-time dependency spdlog found: YES 1.9.2
Run-time dependency wayland-client found: YES 1.19.0
Run-time dependency wayland-cursor found: YES 1.19.0
Run-time dependency wayland-protocols found: YES 1.23
Run-time dependency gtkmm-3.0 found: YES 3.24.5
Run-time dependency dbusmenu-gtk3-0.4 found: YES 16.04.0
Run-time dependency gio-unix-2.0 found: YES 2.70.1
Run-time dependency jsoncpp found: YES 1.9.4
Run-time dependency sigc++-2.0 found: YES 2.10.7
Did not find CMake 'cmake'
Found CMake: NO
Run-time dependency epoll-shim found: NO (tried pkgconfig and cmake)
Run-time dependency libnl-3.0 found: YES 3.5.0
Run-time dependency libnl-genl-3.0 found: YES 3.5.0
Run-time dependency libpulse found: YES 14.2-rebootstrapped
Run-time dependency libudev found: YES 249
Run-time dependency libevdev found: YES 1.11.0
Run-time dependency libmpdclient found: YES 2.19
Run-time dependency xkbregistry found: YES 1.3.1
Library sndio found: YES
Checking for function "sioctl_open" with dependency -lsndio: YES
Run-time dependency gtk-layer-shell-0 found: YES 0.6.0
Dependency systemd skipped: feature systemd disabled
Run-time dependency date found: YES
Program wayland-scanner found: YES (/nix/store/5ga7z245k9sk5cf4a51migv5lrxl4my7-wayland-1.19.0-bin/bin/wayland-scanner)
Program gdbus-codegen found: YES (/nix/store/wvnnkil0zb1xnn8xdfngxiaqahja77r2-glib-2.70.1-dev/bin/gdbus-codegen)
Found pkg-config: /nix/store/0pymd6cd7kaj6lrxgcficbd232zrpdi3-pkg-config-wrapper-0.29.2/bin/pkg-config (0.29.2)
Build-time dependency scdoc found: YES 1.11.2
Program /nix/store/km50k8babybnpa9cydgh23l47mrbfxhw-scdoc-1.11.2/bin/scdoc found: YES (/nix/store/km50k8babybnpa9cydgh23l47mrbfxhw-scdoc-1.11.2/bin/scdoc)
Program sh found: YES (/nix/store/svxmj4xahyjqq4lciisvgi1fwl5bxpdd-bash-5.1-p8/bin/sh)
Configuring waybar.5.scd using configuration
Run-time dependency catch2 found: NO (tried pkgconfig and cmake)
Looking for a fallback subproject for the dependency catch2

meson.build:381:0: ERROR: Automatic wrap-based subproject downloading is disabled

A full log can be found at /build/source/build/meson-logs/meson-log.txt
error: builder for '/nix/store/yql2lhscvpkilyxhxh4kqg8w1zr3ymd5-waybar-0.9.9.drv' failed with exit code 1
error: 1 dependencies of derivation '/nix/store/h4xjj34m0s7x2aqdfr3108a4wfn6iyib-system-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/6w5bscy91m6ycwpc9009k0y6pz3xniby-nixos-system-wombat11k-21.11.git.76f5b6bb9cfM.drv' failed to build
Synthetica9 commented 2 years ago

Already an open PR, https://github.com/NixOS/nixpkgs/pull/155243#pullrequestreview-853710398

mhwombat commented 2 years ago

Sorry about that. I searched "issues" when I should have searched "pull requests".