search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.19k stars 14.2k forks source link

GNSS_SDR: add -DENABLE_OSMOSDR=ON to build flags #159996

Open Split7fire opened 2 years ago

Split7fire commented 2 years ago

While working with gnss-sdr found out that gnss-sdr package in nixos built without osmosdr support. Looking through nixos packages confirm this. Can we just add add -DENABLE_OSMOSDR=ON to cmakeFlags?

Mindavi commented 2 years ago

I think that's possible, now building with that flag. How can I best test if it actually works?

Note: it does log this at least: " * ENABLE_OSMOSDR, Enables Osmosdr_Signal_Source and RtlTcp_Signal_Source for using RF front-ends compatible with the OsmoSDR driver. Requires gr-osmosdr."

Note 2: It does at least build with that flag enabled :)

Split7fire commented 2 years ago

Note 2: It does at least build with that flag enabled :)

That's great! I think best option to test it is to start gnss-sdr with OsmoSDR clients. So I can test it and reply whether it works or not.

Split7fire commented 2 years ago

@Mindavi checking nixos packages and not find OSMOSDR flag. That is the status?

Mindavi commented 2 years ago

Sorry for the slow response. I'm not sure how to test it, that's why I didn't enable it. To me it doesn't make sense to add it without testing, but it could be done. It does feel quite safe, even if it doesn't work, it presumably won't break other functionality (but don't quote me on that).

Split7fire commented 2 years ago

I'm not sure how to test it I know how to test it ) I have HackRF and want to use it with osmosdr. But I just don't understand how to override package with this option. That's why I asked for "test".

Mindavi commented 2 years ago

@bjornfor could you have a look at this? I'm not really sure where to begin.

bjornfor commented 2 years ago

I don't have that HW but if someone writes a PR to add support I can help with merging.

Mindavi commented 2 years ago

Yeah, I tried building with that flag again but now it errored out, so I think it's more complicated than I previously thought it was. Maybe try to contact other gnuradio maintainers @Split7fire