NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.18k stars 14.19k forks source link

nixos logo stretched on isolinux splash screen #168434

Open davidak opened 2 years ago

davidak commented 2 years ago

Describe the bug

A clear and concise description of what the bug is.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Boot Installer on BIOS system

Expected behavior

Logo should have the correct proportions.

Screenshots

IMG_20220413_012720

Additional context

This was always an issue and it annoys me every time i boot the installer. There might be already an issue, but i have not found it.

Notify maintainers

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
output here
bbjubjub2494 commented 2 years ago
  1. I think this is isolinux, not GRUB. ISOs currently use GRUB for EFI.
  2. Is this the standard ISO or a custom one?
  3. What graphic card and what resolution? This has a lot of influence on bootloader graphics.
davidak commented 2 years ago
  1. yes, looks similar to other isolinux screenshots. changed
  2. custom ISO from https://github.com/NixOS/nixpkgs/pull/161788, but that part is used from standard ISO i guess
  3. AMD Radeon RX 6600 XT, but also on every other system (Nvidia, Intel). The screen is 16:9, maybe the image is 4:3 and stretched?

https://github.com/NixOS/nixpkgs/blob/2ddc335e6f32b875e14ad9610101325b306a0add/nixos/modules/system/boot/loader/grub/grub.nix#L432

i suppose it's this file: https://github.com/NixOS/nixos-artwork/blob/master/bootloader/isolinux/bios-boot.png

it is 800x600 (4:3), so we would have to change that file. it will look bad on 4:3 screens then, but they are the minority nowadays. maybe it is possible to not stratch the image and have white borders on the sides that blend over

maybe full hd (1920x1080) would be good, to have a quality image, if technically possible (maybe not)

debian seem to use 16:8 (640x300) https://wiki.debian.org/DebianDesktop/Artwork/Requirements (if that's not outdated)

some ressources:

https://wiki.archlinux.org/title/syslinux#Graphical_boot_menu

https://wiki.syslinux.org/wiki/index.php?title=Menu#MENU_RESOLUTION https://wiki.syslinux.org/wiki/index.php?title=Menu#MENU_BACKGROUND https://wiki.syslinux.org/wiki/index.php?title=Common_Problems#Menu_background

To prevent your final splash image from looking distorted start with an image that perfectly matches the aspect ratio of your screen. For example: if your screen is 16:9, start with an image of size 1366x768 or 1600x900 or 1920x1080 and resize it to 640x480.

Source: https://forum.porteus.org/viewtopic.php?t=4965