gador
commented
2 years ago can confirm for aarch64-linux and x86_64-linux
Closed samuela closed 2 years ago
gador
commented
2 years ago can confirm for aarch64-linux and x86_64-linux
samuela
commented
2 years ago I'm trying to bisect this atm, but it's a truly massive undertaking since there's hundreds of commits between current master and the last successful build... plus there's lots of other irrelevant failures :/
samuela
commented
2 years ago I was unable to find the exact commit that caused these failures, since it was interlaced a bunch of other commits that broke dependencies.
Created https://github.com/getsentry/sentry-python/issues/1398 upstream. We'll see what they say. We're not doing any patching of required dependency versions, so the test suite ought to be passing.
gador
commented
2 years ago I also tried bisecting. Due to the massive rebuilds, I canceled after 8 hours and did a bisect with first-parent.
The bad commit is 95af2245a32f8e1310ad4e3bf50b76d86ddbbc0a from #168737, which is a merge from staging with changes to python and others:
Looking at the test-requirements there is a requirement for werkzeug < 2.1.0. When applied, the test mostly pass. The only failing test is:
=================================== FAILURES ===================================
___________________________ test_cli_commands_raise ____________________________
tests/integrations/flask/test_flask.py:503: in test_cli_commands_raise
app.cli.main(
/nix/store/jx97i20a84abbr6hsalwxvcr9m00sphh-python3.9-click-8.1.2/lib/python3.9/site-packages/click/core.py:1055: in main
rv = self.invoke(ctx)
/nix/store/jx97i20a84abbr6hsalwxvcr9m00sphh-python3.9-click-8.1.2/lib/python3.9/site-packages/click/core.py:1657: in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
/nix/store/jx97i20a84abbr6hsalwxvcr9m00sphh-python3.9-click-8.1.2/lib/python3.9/site-packages/click/core.py:1404: in invoke
return ctx.invoke(self.callback, **ctx.params)
/nix/store/jx97i20a84abbr6hsalwxvcr9m00sphh-python3.9-click-8.1.2/lib/python3.9/site-packages/click/core.py:760: in invoke
return __callback(*args, **kwargs)
/nix/store/jx97i20a84abbr6hsalwxvcr9m00sphh-python3.9-click-8.1.2/lib/python3.9/site-packages/click/decorators.py:26: in new_func
return f(get_current_context(), *args, **kwargs)
/nix/store/hpscxkmgv6lvvygm480nkd32iyhwwss8-python3.9-Flask-2.1.1/lib/python3.9/site-packages/flask/cli.py:426: in decorator
with __ctx.ensure_object(ScriptInfo).load_app().app_context():
/nix/store/hpscxkmgv6lvvygm480nkd32iyhwwss8-python3.9-Flask-2.1.1/lib/python3.9/site-packages/flask/cli.py:382: in load_app
app = self.create_app()
E TypeError: <lambda>() missing 1 required positional argument: '_'There is also a requirement for pytest < 7. Since this packaged builds with the latest nixos/unstable, which includes pytest 7.0.1 I am now testing with that version.
fabaff
commented
2 years ago The updates usually breaks the package. I guess from 1.5.7 to 1.5.8.
Edit: Was part of python-updates
gador
commented
2 years ago Further investigation:
When I apply the following two changes:
flask to 2.0.3werkzeug to 2.0.3 sentry-sdk builds without issues.
How should we go about this?
werkzeug SDK).sentry-sdk for those two packages could lead to potential breakages due to dual imports of two different werkzeug or flask imports in packages, which import sentry-sdk and one of the two packages.Obviously it would be awesome if upstream update their end of the SDK of werkzeug. This could take some time and sentry-sdk is needed by other packages.
samuela
commented
2 years ago I notified the authors of the breaking commits https://github.com/NixOS/nixpkgs/commit/3caf52bdc1141f4bd33e69abebaaa316e6e23186#commitcomment-71646691 and https://github.com/NixOS/nixpkgs/commit/7c557ca93e0f6494b8fac233820b55be096ea99e#commitcomment-71646699.
gador
commented
2 years ago Another breakage is pgadmin (tracked in #169322)
fabaff
commented
2 years ago Adding an override in sentry-sdk for those two packages could lead to potential breakages due to dual imports of two different werkzeug or flask imports in packages, which import sentry-sdk and one of the two packages.
Module can't have overrides. Thus, till the issues are fixed by upstream the failing tests should be disabled.
nixos-discourse
commented
2 years ago This issue has been mentioned on NixOS Discourse. There might be relevant details there:
Issue description
Build of
python39Packages.sentry-sdkfailed on x86_64-linux as of 891d0226de6e281422a8d0d99814925fd7aed8d0. This is currently breaking python3Packages.wandb.full build log
python3Packages.wandb maintainers cc: @samuela python39Packages.sentry-sdk maintainers cc: @fabaff @gebner Other cc: n/a
Steps to reproduce
nix-build -A python39Packages.sentry-sdkTechnical details
Misc.
This issue was automatically generated by nixpkgs-upkeep.