Munin: ability to use plugins from munin-contrib

[domenkozar]

Munin has a wide range of plugins at https://github.com/munin-monitoring/contrib, we should support using them.

I'm particularly interested into raid monitoring at the moment.

[danbst]

I have a WIP for munin 2.999, and rework for munin service (munin 3 will contain nice webui standalone server). Should I publish this WIP? It has some plugins fixed, and community plugins are on my todo List.

[domenkozar]

Sure! I'd prefer to use stable version but let's see if something can be extracted :)

[domenkozar]

@danbst did you get somewhere with this?

[Profpatsch]

(triage) can we close this in favor of the PR?

[danbst]

@Profpatsch I've closed the PR, let's leave this open

[ToxicFrog]

A workable stopgap until full contrib support can be implemented might be:

1. add a services.munin-node.extraPluginConfig option that's appended to munin-plugin.conf, in the same manner as services.munin-node.extraConfig
2. add a services.munin-node.extraPlugins option that lists additional plugin files to be symlinked into /etc/munin/plugins; at the moment it just blindly accepts whatever munin-node-configure outputs
3. add a services.munin-node.disabledPlugins to replace the existing hard-coded disablement of diskstats (which may not even be needed anymore, but if it is we can make that the default value)

This lets users disable plugins at will (useful since munin-node-configure tends to be very aggressive in what it enables), and add new plugins by manually downloading them and referencing them from extraPlugins -- which isn't as nice as having all the contrib plugins available as part of the munin build, but is an improvement on the status quo.

[ToxicFrog]

I started work on this. It's more complicated than it looks, and I ran into some other issues I want to fix while I'm in there, but it's coming along nicely.

[florianjacob]

@ToxicFrog Feel free to mention me when the PR is ready to provide you with a review and an independent test run.

[ToxicFrog]

@florianjacob #51980

[florianjacob]

As #51980 was merged, this should be resolved now.

[ToxicFrog]

IMO this isn't fully resolved until munin-contrib is also packaged so users don't have to manually download it and fish individual plugins out of it for use with extraPlugins -- this should be pretty simple, I just haven't had the bandwidth to do it.

[florianjacob]

Makes sense, I thought those were delivered with the main package already.

[ToxicFrog]

No, only the core munin plugins are (contrib is a separate and much more eclectic repo) and I was in a hurry and already had munin-contrib checked out in /usr/src, so I added a feature to load arbitrary munin plugins, pointed that at my local checkout and concluded that was good enough for the moment.

Once munin-contrib is packaged it means that stuff like this:

extraAutoPlugins = [
  /usr/src/munin-contrib/plugins/zfs
];

gets replaced with this:

extraAutoPlugins = [
  ${pkgs.munin-contrib}/plugins/zfs
];

while still letting users who have written their own plugins outside contrib reference them directly in extraPlugins and extraAutoPlugins.

I don't think munin-contrib needs any sort of installation procedure, it's just fetch+unpack, so I may see if I can get it packaged soon. It should be an easy review so hopefully it doesn't languish unmerged for too long and then we can close this.

[stale[bot]]

Hello, I'm a bot and I thank you in the name of the community for opening this issue.

To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it.

If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use Git blame or GitHub's web interface on the relevant files to find them.

Lastly, you can always ask for help at our Discourse Forum or at #nixos' IRC channel.

[ToxicFrog]

This is still relevant.

[stale[bot]]

I marked this as stale due to inactivity. → More info