geeqie: missing webp support

t-gebauer commented 2 years ago

Describe the bug

Geeqie in nixpkgs (version 1.7.3) does not seem to support webp.

webp images are not displayed
webp files do not appear in the file viewer
webp does not appear in the [Preferences : Files : File Types] list

Steps To Reproduce

Steps to reproduce the behavior:

find a webp image (e.g. https://upload.wikimedia.org/wikipedia/commons/a/a1/Johnrogershousemay2020.webp)
and open it geeqie Johnrogershousemay2020.webp

Expected behavior

Geeqie displays the image.

Additional context

Geeqie supports webp since 1.6

Adding libwebp to buildInputs fixes this. However, thumbnails are still broken/missing.

geeqie.overrideAttrs (drv: { buildInputs = drv.buildInputs ++ [libwebp]; })

Notify maintainers

@jfrankenau @pSub @markus1189

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

└> nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.40-xanmod1, NixOS, 22.05 (Quokka), 22.05.1711.c06d5fa9c60`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.8.1`
 - channels(root): `"nixos-22.05, nixos-unstable, unstable"`
 - channels(user): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

trofi commented 2 years ago

Looks very reasonable. Would you like to propose a PR for it?

milahu commented 2 years ago

just add libwebp to buildInputs

we may want to add other libs while we're at it

config summary with webp:

Localization:
  NLS support:   yes
  LINGUAS:        ar be bg ca cs da de el en_GB eo es et eu fi fr hu id it ja ko nb nl pl pt_BR ro ru sk sl sr@latin sr sv th tlh tr uk vi zh_CN zh_TW

Settings:
  Developer:     no
  Debug flags:   no
  Debug log:     yes
  Deprecated:    no

Support:
  LCMS:          yes
  Exiv2:         yes
  Lirc:          no
  Clutter:       yes
  Libchamplain:         yes
  Libchamplain-gtk:     yes
  Lua:           no
  FFmpegthumbnailer:    yes
  Pdf:           no
  HEIF:          no
  WebP:          yes
  DjVu:          no
  J2K:           no
  LibRaw:        no
  Libjxl:        no
  Libarchive:    no

Documentation:
  Doxygen:       /nix/store/dyx1qgccr98zkwgskg1q42syx90nqc7d-doxygen-1.9.4/bin/doxygen
  doc-tool:

NixOS / nixpkgs