search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.08k stars 14.13k forks source link

WebCord #183061

Closed huantianad closed 1 year ago

huantianad commented 2 years ago

Project description Alternate Discord and Fosscord client made to be private, secure, customizable, and Linux friendly.

Metadata

epetousis commented 2 years ago

I had a shot at trying to package this from source, but it seems that for whatever reason, the nixpkgs' Electron crashes with SIGTRAP when trying to run with source. I haven't had much luck using strace on Electron to find a root cause either. Haven't tried using the AppImage yet, though.

huantianad commented 2 years ago

I don't think the appimage will have much difference, but I've also gotten the same error. There is now a flake that uses dream2nix to package it properly

epetousis commented 2 years ago

I made a derivation that doesn't use dream2nix, and it's available at https://github.com/epetousis/dotfiles/tree/main/overlays/webcord if it's of any use. The SIGTRAP issue was just a bad Electron version, from what I could tell. I haven't submitted this to nixpkgs yet purely because I want #189539 merged first.

huantianad commented 2 years ago

Ah it would make sense for the SIGTRAP to be an electron version issue, I've had it on a few other electron apps too.

Your derivation looks pretty good, might try it out. Wonder how long it will take the pr you mentioned to be finished tho

epetousis commented 2 years ago

The PR has been marked as a blocker for 22.11, so at the very latest, end of November. May be an excessive amount of time to wait, though.

huantianad commented 1 year ago

Now that buildNpmPackage is mostly done and merged, I've used it to make a nice and simple derivation for it: https://github.com/huantianad/nixos-config/blob/main/packages/webcord.nix

epetousis commented 1 year ago

Looks great. Not sure if you're planning on submitting this to nixpkgs, but if you are it might be worth adding arm64 support as well.

huantianad commented 1 year ago

Yeah it would be nice to get this to work on aarch64 and/or darwin too, but I don’t have any devices to test it on. Can you help with this? The package might already even work on arm since we're just wrapping nixpkgs electron.

I’m also down to put this on nixpkgs, might wanna do a bit more testing and tweaking; if you can see any places for improvement that'd be great!

TheArcaneBrony commented 1 year ago

is there anything that would stop this package from running on i686?