NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.28k stars 14.27k forks source link

Celestia: wrong executable name in desktop file #187877

Open orbistertius opened 2 years ago

orbistertius commented 2 years ago

Describe the bug

The installed desktop file calls "celestia-gtk" while the installed binary is "celestia":

[emiliano@galactica:~]$ cat /nix/store/1n7hjw6q91l8806gc25lfhxz5bxky570-celestia-1.6.2.2/share/applications/celestia.de
sktop 
[Desktop Entry]
Encoding=UTF-8
Version=1.0
Type=Application
Exec=celestia-gtk
Icon=celestia
X-GNOME-DocPath=
Terminal=false
Name=Celestia (Gtk+)
GenericName=Space Simulator
Comment=Explore the Universe in this detailed space simulation
StartupNotify=true
Categories=Astronomy;Education;Application;
[emiliano@galactica:~]$ ls /nix/store/1n7hjw6q91l8806gc25lfhxz5bxky570-celestia-1.6.2.2/bin
celestia

Steps To Reproduce

Add celestia to environment.systemPackages in /etc/configuration.nix

Expected behavior

It should be possible to start celestia from dmenu or rofi with desktop file.

Screenshots

5_001

5_002

Additional context

Notify maintainers

@hjones2199

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[emiliano@galactica:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.60, NixOS, 22.05 (Quokka), 22.05.2583.00e376e3f3c`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.8.1`
 - channels(emiliano): `"home-manager-22.05.tar.gz"`
 - channels(root): `"home-manager-22.05.tar.gz, nixos-22.05, nixos-unstable"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
tye-singwa commented 2 years ago

Hi! Just noticed that patch is already in https://github.com/CelestiaProject/Celestia/pull/938, but not in current version 1.6.2.2