i686 Clang Cross Compilation fixes: Tracker

NixOS / nixpkgs

Nix Packages collection & NixOS

MIT License

16.55k stars 13.04k forks source link

i686 Clang Cross Compilation fixes: Tracker #195967

Open peperunas opened 1 year ago

peperunas commented 1 year ago

Describe the bug

This is a tracking issue for several bugfixes on different derivations when cross-compiling for i686 or with a clang-only toolchain (useLLVM = true).

cc/ @Ericson2314

musl (#195969)
libvorbis (#195968)
cc-wrapper (#196013)
audiofile (#195971)
apparmor (#195972)
gnu-efi (#195974)
libnftnl (#195975)
LLVM (#196006, #196008, #196023)
dbus (#195977)
pulseaudio (#195979)
SDL(#195981)
elfutils (#195980)
pkgsi686Linux (#195983)

risicle commented 1 year ago

Perhaps related: #97688

alyssais commented 1 year ago

Hi @peperunas, I've looked through a few of these PRs now, and I've found that most of them are missing detailed explanations for the changes in the commit message bodies. This makes it difficult for reviewers to understand why the changes are required, and it means that if something goes wrong with one of the changes (e.g. https://github.com/NixOS/nixpkgs/pull/200587) it's more likely to get reverted rather than fixed, as it's difficult for the person who notices the changes to try to fix it if they don't know how they should be testing they haven't broken your use case.

(When adding these explanations, please make sure they're in the commit message bodies rather than just the PR comments, so that they show up in git log etc.)