All labels should have descriptions

yukiisbored commented 1 year ago

Problem

Currently the nixpkgs repository has 167 labels and most of them lack a description of what each of them mean. This is especially confusing with labels such as 8.has: package (new), 8.has: package (update) which aren't clear, even if you look at the list of issues.

Checklist

[x] checked latest Nixpkgs manual (source) and latest NixOS manual (source)
[x] checked open documentation issues for possible duplicates
[x] checked open documentation pull requests for possible solutions

Proposal

Every single label must have a clear and concise description on what they mean and what kind of issues / pull requests should have them.

seam345 commented 1 year ago

This would be great to see and helpful for new maintainers.

For example: At the moment struggling to workout if 12.approvals: 1 is anyone has commented saying the approve/tested the PR or if it's a maintainer that approves. A description to the label would help clarify.

FliegendeWurst commented 9 months ago

At the moment struggling to workout if 12.approvals: 1 is anyone has commented saying the approve/tested the PR or if it's a maintainer that approves. A description to the label would help clarify.

"12.approvals: x" is based on hitting the approve button in Github's UI. If a maintainer approves, it will also add the "12.approved-by: package-mantainer" label. See #264633. I definitely agree that it should be documented.

NixOS / nixpkgs