NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.13k stars 13.42k forks source link

llvmPackages_13+: missing llvm-polly #205032

Open LunNova opened 1 year ago

LunNova commented 1 year ago

llvmPackages_11 has llvm-polly, llvmPackages_13 and newer do not have it and overriding with enablePolly = true does not build.

I also noticed it seems hard to correctly override part of an llvm package set and have override used in all other parts of the package set that should depend on it. It's possible to do this for llvmPackages_x.tools but not the entire llvmPackages_x.

ccing maintainers @lovek323 @raskin @dtzWill @primeos

Click for failed build log with enablePolly ``` llvm> applying patch /nix/store/x7xvhn22s8sr7scpp2pcpwcix7170ach-gnu-install-dirs-polly.patch llvm> can't find file to patch at input line 5 llvm> Perhaps you used the wrong -p or --strip option? llvm> The text leading up to this was: llvm> -------------------------- llvm> |diff --git a/tools/polly/CMakeLists.txt b/tools/polly/CMakeLists.txt llvm> |index ca7c04c565bb..6ed5db5dd4f8 100644 llvm> |--- a/tools/polly/CMakeLists.txt llvm> |+++ b/tools/polly/CMakeLists.txt llvm> -------------------------- llvm> File to patch: llvm> Skip this patch? [y] llvm> Skipping patch. llvm> 2 out of 2 hunks ignored llvm> can't find file to patch at input line 37 llvm> Perhaps you used the wrong -p or --strip option? llvm> The text leading up to this was: llvm> -------------------------- llvm> |diff --git a/tools/polly/cmake/CMakeLists.txt b/tools/polly/cmake/CMakeLists.txt llvm> |index 7cc129ba2e90..137be25e4b80 100644 llvm> |--- a/tools/polly/cmake/CMakeLists.txt llvm> |+++ b/tools/polly/cmake/CMakeLists.txt llvm> -------------------------- llvm> File to patch: llvm> Skip this patch? [y] llvm> Skipping patch. llvm> 2 out of 2 hunks ignored llvm> can't find file to patch at input line 82 llvm> Perhaps you used the wrong -p or --strip option? llvm> The text leading up to this was: llvm> -------------------------- llvm> |diff --git a/tools/polly/cmake/polly_macros.cmake b/tools/polly/cmake/polly_macros.cmake llvm> |index 518a09b45a42..bd9d6f5542ad 100644 llvm> |--- a/tools/polly/cmake/polly_macros.cmake llvm> |+++ b/tools/polly/cmake/polly_macros.cmake llvm> -------------------------- llvm> File to patch: llvm> Skip this patch? [y] llvm> Skipping patch. llvm> 1 out of 1 hunk ignored llvm> can't find file to patch at input line 97 llvm> Perhaps you used the wrong -p or --strip option? llvm> The text leading up to this was: llvm> -------------------------- llvm> |diff --git a/tools/polly/lib/External/CMakeLists.txt b/tools/polly/lib/External/CMakeLists.txt llvm> |index 8991094d92c7..178d8ad606bb 100644 llvm> |--- a/tools/polly/lib/External/CMakeLists.txt llvm> |+++ b/tools/polly/lib/External/CMakeLists.txt llvm> -------------------------- llvm> File to patch: llvm> Skip this patch? [y] llvm> Skipping patch. llvm> 1 out of 1 hunk ignored ```
rrbutani commented 3 months ago

IIRC this was "fixed" in llvmPackages_15 and then backported to llvmPackages_14: https://github.com/NixOS/nixpkgs/pull/218806.

Leaving this issue open as llvmPackages_13 still is not built with polly support (unfortunately I cannot update the title/OP accordingly)