NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.45k stars 13.65k forks source link

Vulnerability Roundup 13 #21142

Closed grahamc closed 7 years ago

grahamc commented 7 years ago

Here are all the vulnerabilities from https://lwn.net/Vulnerabilities since our last roundup.

cc: @NeQuissimus @vcunat @joachifm.

Note: The list of people CC'd on this issue participated in the last roundup. If you participate on this roundup, I'll cc you on the next one. If you don't participate in the next one, you won't be CC'd on the one after that. If you would like to be CC'd on the next roundup, add a comment to the most recent vulnerability roundup. If you would like to be CC'd on all roundups, leave a comment and tell @grahamc so.

Permanent CC's: @joepie91, @phanimahesh, @NixOS/security-notifications (if you no longer want to be CC'd, ask to be removed from this list)

Notes on the list

  1. The reports have been roughly grouped by the package name. This isn't perfect, but is intended to help identify if a whole group of reports is resolved already.
  2. Some issues will be duplicated, because it affects multiple packages. For example, there are sometimes problems that impact thunderbird, and firefox. LWN might report in one vulnerability "thunderbird firefox". These names have been split to make sure both packages get addressed.
  3. By each issue is a link to code search for the package name, and a Github search by filename. These are to help, but may not return results when we do in fact package the software. If a search doesn't turn up, please try altering the search criteria or looking in nixpkgs manually before asserting we don't have it.
  4. This issue is created by https://github.com/NixOS/security

Instructions:

  1. Triage a report: If we don't have the software or our version isn't vulnerable, tick the box or add a comment with the report number, stating it isn't vulnerable.
  2. Fix the issue: If we do have the software and it is vulnerable, either leave a comment on this issue saying so, even open a pull request with the fix. If you open a PR, make sure to tag this issue so we can coordinate.
  3. When an entire section is completed, move the section to the "Triaged and Resolved Issues" details block below.

Upon Completion ...

Without further ado...

Assorted (36 issues)

jasper (2 issues)

kernel (8 issues)

systemd (2 issues)

xen (2 issues)

grahamc commented 7 years ago

I've got a jasper update in the works. Checking to see if 2.0.6 is BC with 1.900.x or not.

NeQuissimus commented 7 years ago

kernel: #708869 (search, files) kernel: denial of service

This needs a patch from https://bugzilla.kernel.org/show_bug.cgi?id=189851 I am not home, so I can't do it until late tonight.

All the other kernel vulns are covered by the kernel versions we have.

grahamc commented 7 years ago

Thank you, @NeQuissimus, I'll apply that patch.

NeQuissimus commented 7 years ago

Let's also mention #21135 (firefox: 50.0.2 -> 50.1.0, firefox-esr: 45.5.1esr -> 45.6.0esr) in here, even though I don't see it on the list.

grahamc commented 7 years ago

Good idea, https://github.com/NixOS/nixpkgs/pull/21134 (firefox-bin: 50.0.2 -> 50.1.0) too.

grahamc commented 7 years ago

Hung up on https://github.com/NixOS/nixpkgs/issues/21145 which is blocking channels from moving forward.

NeQuissimus commented 7 years ago

Xen and SystemD are good.

NeQuissimus commented 7 years ago

Looks like unzip needs both the CVEs patched

NeQuissimus commented 7 years ago

I am going to send a PR for subversion once it has built on my machine. It's a straight forward update.

grahamc commented 7 years ago

@domenkozar are you available to look in to upgrading our openstack components?

grahamc commented 7 years ago

Actually, @NeQuissimus, can you apply that kernel patch?

grahamc commented 7 years ago

@makefu can you look in to updating XStatic-jquery-ui?

makefu commented 7 years ago

@grahamc ^

grahamc commented 7 years ago

Thank you!

phanimahesh commented 7 years ago

I started looking at atomic-openshift. Both code and files searches failed to show any results. Past roundups mentioned atomic-openshift a few times, but I couldn't locate the corresponding commits/patches that fixed it.

The derivations for openshift and rhc are both simple. Should I be looking at their commits to see if the fixes have been included? Are they the right repos? How do I find out the corresponding repo and package, in general?

Pointers? How do I proceed?

grahamc commented 7 years ago

oh I don't think we have Atomic, and the one that says cinder is also for glance which we do have: https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/virtualization/openstack/glance.nix.

domenkozar commented 7 years ago

Updating openstack is quite some work as you need to bump all components. It's better to look into patching existing versions, if they're still supported upstream.

bachp commented 7 years ago

I think atomic-openshift refers to the package openshift. RHC is the old (OpenShiftv2) client utility. This is completly different from openshift (OpenShift v3, aka OpenShift Container Platform).

As there is a version 1.3.2 available I think this would be the component to update.

grahamc commented 7 years ago

@bachp can you make that PR?

grahamc commented 7 years ago

@NeQuissimus bump on that kernel patch. Can you do it?

grahamc commented 7 years ago

I think my patches to release 16.09 are bad... will investigate in a few hours.

grahamc commented 7 years ago

I think my patches were good, but the nix / hydra issues are hurting us again.

bachp commented 7 years ago

@grahamc I might find some time to do it this weekend.

NeQuissimus commented 7 years ago

I bumped the kernels just now

bachp commented 7 years ago

@grahamc PR created #21216

grahamc commented 7 years ago

@bachp: Excellent, thank you!

@NeQuissimus Looks great, thank you!

@domenkozar That is part of what I feared, touching Openstack in general spooks me. It looks like there are patch releases within these major releases, 11.0.0 -> 11.0.2... 7.0.0 -> 7.0.2. Are these safe, do you think? Do they all need to go up in lock-step for these patch releases.

grahamc commented 7 years ago

I deleted this one from this week to close it out:

domenkozar commented 7 years ago

Minor bumps would work, but it's quite some python packages to update (sorry, I don't have time now).