[23.05-unstable] tmux + vim paste bug

abyxcos commented 1 year ago

Describe the bug

When running vim inside of tmux and attempting to system paste in insert mode (middle click, shift insert, apple-v, etc) the paste event becomes prefixed with control/escape characters. I have only been able to test this behavior with Apple's Terminal.app sshed in to a nixos machine.

Pasting in to ssh works (no vim, no tmux).
Pasting in vim without tmux works.
Pasting in a bash shell in a tmux window works.
Pasting in to a bash shell executed from vim (:sh command) inside tmux works.
Pasting in to vim running in tmux fails.

Additional context

This only occurs on the 23.05-unstable branch. This works as expected on 22.11. This occurs with both the default vim config and the below config.

cat ~/.vimrc
set nocompatible
set bs=indent,eol,start
set rulerformat=%=%l,%v\ %p%%

syntax off
set hlsearch

Sample file before paste:

a
b
c

[copy the text "https://github.com/NixOS/nixpkgs"] 2Ga " go to second line and enter append mode [press shift-insert]

New file contents:

a
b://github.com/NixOS/nixpkgs
c

Notify maintainers

Vim: @dasJ @equirosa Tmux: @tobias-hammerschmidt @fpletz @SuperSandro2000 @rapenne-s

Metadata

system: "x86_64-linux"
host os: Linux 5.15.93, NixOS, 23.05 (Stoat), 23.05pre452935.724bfc08923
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.13.2
channels(root): "nixos, nixos-hardware"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

abyxcos commented 1 year ago

I cannot replicate this via a UART serial terminal to the machine, so ssh/sshd may be involved?

FlorianFranzen commented 1 year ago

I started having the same issue on unstable with foot and vim under wayland (sway). It is not an issue if I ssh into any of my other hosts, but they also do not run on unstable. (:set paste makes no difference either.)

hxtmdev commented 1 month ago

I had a problem involving escape delays in tmux+vim recently, try fiddling with the timeout settings of tmux and vim and see if that brings new info.

See https://www.johnhawthorn.com/2012/09/vi-escape-delays/

Overall this smells like a race condition, just brainstorming here but maybe:

it only occurs with tmux+vim because of how their handling chains / interacts (tmux waiting X, then forwarding rapidly etc.)
UART does not trigger it because it slows the bytes down just enough to not trigger it while the SSH=TCP connection delivers lots of them in a single packet

NixOS / nixpkgs