NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.98k stars 14k forks source link

Packaging request: nodePackages.prettierd #219761

Closed jay-aye-see-kay closed 1 year ago

jay-aye-see-kay commented 1 year ago

A similar project to prettier_d_slim which is packaged already, that seems to be more active

Project description

prettier, as a daemon, for improved formatting speed.

Metadata

teto commented 1 year ago

do you think the project could add a package-lock.json ? this would allow to use buildNpmPackage which is simpler see https://github.com/NixOS/nixpkgs/issues/229475

dotlambda commented 1 year ago

do you think the project could add a package-lock.json ?

It already has a yarn.lock That can be used in combination with fetchYarnDeps.

linsui commented 1 year ago

I'm confused. I thought this prettierd has been added in https://github.com/NixOS/nixpkgs/pull/241339 but you are talking about repackaging it with buildNpmPackage which requires upsteam changes? Am I miss something?

dotlambda commented 1 year ago

Oh I didn't see that. In that case this issue can be closed. @jay-aye-see-kay If you want you can make a PR adding nodePackages.prettierd as an alias.