Build failure: herbstluftwm

[bstar]

Steps To Reproduce

Steps to reproduce the behavior:

1. build herbstluftwm

Build log

pytestCheckPhase
Executing pytestCheckPhase
============================= test session starts ==============================
platform linux -- Python 3.10.10, pytest-7.2.0, pluggy-1.0.0
rootdir: /build/herbstluftwm-0.9.5, configfile: tox.ini
collected 2352 items / 205 deselected / 2147 selected                          

../tests/test_basic_events.py ......................                     [  1%]
../tests/test_clients.py ............................................... [  3%]
..................................                                       [  4%]
../tests/test_completion.py .....................................        [  6%]
../tests/test_decorations.py ..........................................  [  8%]
../tests/test_doc.py ................................................... [ 10%]
........................................................................ [ 14%]
.....                                                                    [ 14%]
../tests/test_ewmh.py .................................................. [ 16%]
......................................................................   [ 20%]
../tests/test_floating.py .......................................        [ 21%]
../tests/test_frame_decorations.py ....                                  [ 22%]
../tests/test_global_commands.py ....................................... [ 23%]
.......                                                                  [ 24%]
../tests/test_herbstclient.py .......................................... [ 26%]
.................................                                        [ 27%]
../tests/test_herbstluftwm.py ................                           [ 28%]
../tests/test_hook.py ......                                             [ 28%]
../tests/test_keybind.py ............................................... [ 30%]
....................................................                     [ 33%]
../tests/test_layout.py ................................................ [ 35%]
........................................................................ [ 38%]
........................................................................ [ 42%]
........................................................................ [ 45%]
........................................................................ [ 48%]
.....................................................                    [ 51%]
../tests/test_load.py .................................................. [ 53%]
............................                                             [ 55%]
../tests/test_meta_commands.py ......................................... [ 56%]
........................................................................ [ 60%]
.............................................................F.......... [ 63%]
........                                                                 [ 64%]
../tests/test_monitor.py ............................................... [ 66%]
........................................................................ [ 69%]
............................                                             [ 70%]
../tests/test_monitor_detection.py .......                               [ 71%]
../tests/test_mousebind.py ............................................. [ 73%]
........................................................................ [ 76%]
........................................................................ [ 80%]
........................................................................ [ 83%]
........................................................................ [ 86%]
..................                                                       [ 87%]
../tests/test_panels.py ........................                         [ 88%]
../tests/test_python_binds.py .................                          [ 89%]
../tests/test_settings.py .............................                  [ 90%]
../tests/test_smoke.py .                                                 [ 90%]
../tests/test_spawn.py ...                                               [ 91%]
../tests/test_stack.py ........................................          [ 92%]
../tests/test_tags.py .................................................. [ 95%]
.........................................................                [ 97%]
../tests/test_theme.py .................                                 [ 98%]
../tests/test_types.py ..............                                    [ 99%]
../tests/test_watchers.py .......                                        [ 99%]
../tests/test_x11.py ........                                            [100%]

=================================== FAILURES ===================================
__________________________ test_foreach_invalid_flag ___________________________

hlwm = <conftest.HlwmBridge object at 0x7fffeba801c0>

    def test_foreach_invalid_flag(hlwm):
        hlwm.call_xfail('foreach C --filter-typo=X tags. echo C') \
            .expect_stderr('"" has no child named "--filter-typo=X"')
        hlwm.call_xfail('foreach C --filter-name=( tags. echo C') \
>           .expect_stderr('Parenthesis is not closed')

../tests/test_meta_commands.py:848: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self2 = CompletedProcess(args=['/build/herbstluftwm-0.9.5/build/herbstclient', '-n', 'foreach', 'C', '--filter-name=(', 'tags...., stdout='', stderr='foreach: Cannot parse flag "--filter-name=(": Mismatched \'(\' and \')\' in regular expression\n')
needle = 'Parenthesis is not closed', regex = True

    def f(self2, needle, regex=True):
        if regex:
>           assert re.search(needle, self2.stderr)
E           assert None
E            +  where None = <function search at 0x7ffff74f91b0>('Parenthesis is not closed', 'foreach: Cannot parse flag "--filter-name=(": Mismatched \'(\' and \')\' in regular expression\n')
E            +    where <function search at 0x7ffff74f91b0> = re.search
E            +    and   'foreach: Cannot parse flag "--filter-name=(": Mismatched \'(\' and \')\' in regular expression\n' = CompletedProcess(args=['/build/herbstluftwm-0.9.5/build/herbstclient', '-n', 'foreach', 'C', '--filter-name=(', 'tags...., stdout='', stderr='foreach: Cannot parse flag "--filter-name=(": Mismatched \'(\' and \')\' in regular expression\n').stderr

../tests/conftest.py:108: AssertionError

Additional context

This error happens during the "pytestCheckPhase"

Executing pytestCheckPhase
============================= test session starts ==============================
platform linux -- Python 3.10.10, pytest-7.2.0, pluggy-1.0.0
rootdir: /build/herbstluftwm-0.9.5, configfile: tox.ini
collected 2352 items / 205 deselected / 2147 selected

I tried installing Python3.10.10, but this error persists. I'm assuming there's an issue with the "test_meta_commands.py" test.

Notify maintainers

@ThibautMarty

Metadata

 - system: `"x86_64-linux"`
 - host os: `Linux 6.2.2, NixOS, 23.05 (Stoat), 23.05pre460365.3c5319ad3aa`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.13.3`
 - channels(root): `"nixos"`
 - channels(bstar): `"home-manager-22.11.tar.gz, nixos-22.11, nixpkgs"`
 - nixpkgs: `/home/bstar/.nix-defexpr/channels/nixpkgs`

[ThibautMarty]

This had been fixed by #220133.