Open vassilmladenov opened 1 year ago
This project doesn't have a license, https://github.com/autobrr/autobrr/issues/416. This seems not allowed in nixpkgs.
it is allowed, we just have it make it unfree
As of today we now have a license for the project! https://github.com/autobrr/autobrr/pull/897
We went with GPLv2-or-later so there should be no more blockers on this issue.
FWIW, packaging the web UI from source is ~basically impossible with our current tooling 😕, unless we embed a lockfile.
We could do some magic and extract the web UI from the binaries provided by the project (assuming a tool has been created to extract go:embed
ded files from binaries), or persuade upstream (hi, @zze0s!) to provide a web UI build along with releases.
...or we could just embed a lockfile.
https://github.com/autobrr/autobrr/commit/762a0bb36bda522084d97463ee4dab8f3e23cef8
:/ Not much we can do with that for now, unless we embed a lockfile, or have upstream supply the web UI as a release asset. This may be best as an out of tree package, for now.
I'm working on this: https://github.com/NixOS/nixpkgs/pull/239107
I embedded a lock file.
@zze0s would it make sense to make a PR and add a lockfile to the Autobrr project itself? Is there any good reason for not adding it?
@zze0s would it make sense to make a PR and add a lockfile to the Autobrr project itself? Is there any good reason for not adding it?
Hey, sorry for the delay, did not see this earlier.
We do have a lockfile for the web, web/pnpm-lock.yaml.
Are you not able to use pnpm for the build?
I am, but only if I generate the lockfile 😅.
How about I make a PR for this in Autobrr?
Some reasons why it might be a good idea: https://pnpm.io/git
I am, but only if I generate the lockfile sweat_smile.
How about I make a PR for this in Autobrr?
Some reasons why it might be a good idea: https://pnpm.io/git
It already exists, but it's in the web
dir and not the root :) even linked to it ;)
I think we broke GitHub: https://github.com/NixOS/nixpkgs/pull/283389#issuecomment-1936660428
Project description
An IRC announce automation tool that connects to the *arr services e.g. sonarr.nix.
Metadata