NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.59k stars 13.74k forks source link

Resend missed Nixpkgs Maintainers organization invites #234293

Closed infinisil closed 2 months ago

infinisil commented 1 year ago

The automated NixOS organization invites set up after https://github.com/NixOS/rfcs/pull/39 do not allow eligible users to request an invite again in case they missed it. Ideally there should be automation to allow such users to request another invite, but alternatively a manual solution works too.

This is now the case for at least two users, @ners (who asked me personally) and @hellwolf (see here). If you're also affected by this issue, please leave a comment.

Due to the fact that the implementation for these automatic invites appears to be entirely closed-source (Edit: Turns out some version of the source is at least here), there's no way for anybody to fix this themselves. It also appears that @grahamc is the sole person responsible for maintaining this, but I haven't gotten a response for 2 weeks now after asking to re-invite a user manually.

nixos-discourse commented 1 year ago

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/join-the-package-maintainer-team/3751/66

alyssais commented 1 year ago

alternatively a manual solution works too.

The manual solution is to ask any other org owner to issue an invite, no?

hellwolf commented 1 year ago

Is it possible to create a github workflow that can be triggered by a smaller group and would have the permission to create invite?

infinisil commented 1 year ago

It looks like GitHub workflows can only be triggered by people with write access to the repo: https://github.com/orgs/community/discussions/49688, so this wouldn't work. The suggested workaround is to use issues instead. I'm guessing we could set it up so that people can get a re-invite by commenting in this thread: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#issue_comment

06kellyjac commented 1 year ago

I personally had this issue too. Due to github email spam I mostly rely on GH notifications in the web ui but for some reason the invites don't show there. I also wasn't expecting an immediate invite from being added to maintainer-list.nix and expected it to come later after some consistent contribution

Maybe mentioning "expect a github org invite in your emails" in this header: https://github.com/NixOS/nixpkgs/blob/master/maintainers/maintainer-list.nix#L1-L59 And maybe adding some of this comment to CONTRIBUTING.md would be good?

I'm guessing we could set it up so that people can get a re-invite by commenting in this thread

That sounds good but maybe not just any comment? Maybe a specific format

infinisil commented 1 year ago

That sounds good but maybe not just any comment? Maybe a specific format

For simplicity I'd make it any comment, because the automation would only send an invite if the user is a maintainer but not already in the org. I expect people matching that criteria (but not wanting to be in the org) to not be upset when they get an invite after commenting in a thread called "Resend missed NixOS organization invites" :smile:

hellwolf commented 1 year ago

I am hitting this problem again, I'd like to configure the backport label to https://github.com/NixOS/nixpkgs/pull/237722

Anything short term I could do to unblock myself being able to self service my package maintainer duties?

06kellyjac commented 1 year ago

To label you need to be in the org, to be in the org you need to post here, not really an alternative other than posting elsewhere too.

If you really want a short term solution an option you have right now is to backport the changes yourself without the label automation but it's a bit more effort. Go to release branch -> make new branch -> cherry pick commit you want -> push -> create PR against release branch

hellwolf commented 1 year ago

To label you need to be in the org, to be in the org you need to post here, not really an alternative other than posting elsewhere too.

Okay.. can I haz org membership now pls?

Artturin commented 1 year ago

Im guessing the reason for missing some of them is that the github api is unstable and misses events

infinisil commented 1 year ago

I asked an org admin to add you manually @hellwolf, can you confirm that it worked?

hellwolf commented 1 year ago

@infinisil yes, confirmed! Thank you all!

rardiol commented 1 year ago

Please invite me

NotAShelf commented 1 year ago

I hate to piggyback this, but I've previously failed to establish communication with an org owner. I would also like an invitation, if possible.

nixos-discourse commented 1 year ago

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/where-did-you-get-stuck-in-the-nix-ecosystem-tell-me-your-story/31415/17

nixos-discourse commented 1 year ago

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/join-the-package-maintainer-team/3751/68

zimbatm commented 1 year ago

Invited rardiol and NotAShelf

NotAShelf commented 1 year ago

Got it, thank you.

nbraud commented 10 months ago

Could I be re-invited as well? I wasn't expecting to get an automatic invite when added to maintainers-list.nix, so I only noticed it now (half-a-year too late)

frogamic commented 10 months ago

Hi there, Could I please be re-invited? I didn't see the original invite until it had expired

zimbatm commented 10 months ago

invited frogamic and nbraud

FliegendeWurst commented 10 months ago

@tu-maurice doesn't remember getting an invite and would probably appreciate a re-invite :)

zimbatm commented 10 months ago

invited! :robot:

xrelkd commented 8 months ago

Please invite me, I maintain several packages as well.

zimbatm commented 8 months ago

done :robot:

witchof0x20 commented 6 months ago

Not sure if this is where to ask, but I also missed an invite! resolved for me!

Leixb commented 6 months ago

Same here

zimbatm commented 6 months ago

function executed 🤖

tomberek commented 5 months ago

invite @YvesStraten

(they reached out and said that their invite failed)

YvesStraten commented 5 months ago

The issue is now resolved for me, I managed to make the link work on another device, no idea why it did not work on the first one. Thank you very much @tomberek for your help 🙏

xyven1 commented 4 months ago

Missed my invite when it came by, I wouldn't mind getting that sent by again. @zimbatm

pbsds commented 3 months ago

Please invite my bot account @pbsbot. I want to programmatically muck about with labels and such without fear of accidentally leaking a commit bit key

con-f-use commented 3 months ago

Hi, can I have an invite, pls? @zimbatm @domenkozar

jcaesar commented 2 months ago

Sorry, I also missed the e-mail, I'd also like to ask for a re-invite.

infinisil commented 2 months ago

Since recently we have the new GitHub org owners help desk Matrix channel, which is the new best place to ask for an invite!

Lassulus commented 2 months ago

sent out the outstanding invitations here

pwnwriter commented 1 month ago

Hi @zimbatm , could you please send me an invitation as well? Unfortunately, I missed the original email :(.

nixos-discourse commented 2 weeks ago

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/i-let-my-github-org-invite-expire-by-accident/52258/2