NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.6k stars 13.76k forks source link

Update request: edgedb 2.3.1 → 3.0 #241327

Closed MrFoxPro closed 1 year ago

MrFoxPro commented 1 year ago

Notify maintainers @ranfdev @sirkonst


Note for maintainers: Please tag this issue in your PR.

sirkonst commented 1 year ago

I've tried to update with:

image

but fail an error:

error: failed to run custom build command for `edgedb-cli v3.3.0 (/build/source)`

Caused by:
  process didn't exit successfully: `/build/source/target/release/build/edgedb-cli-ef69b166ca09f3e5/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-changed=/build/source/tests/shared-client-testcases/connection_testcases.json

  --- stderr
  thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', build.rs:90:73
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

I don't have an idea yet to solve it...

MrFoxPro commented 1 year ago

I've tried to update with:

image

but fail an error:

error: failed to run custom build command for `edgedb-cli v3.3.0 (/build/source)`

Caused by:
  process didn't exit successfully: `/build/source/target/release/build/edgedb-cli-ef69b166ca09f3e5/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-changed=/build/source/tests/shared-client-testcases/connection_testcases.json

  --- stderr
  thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', build.rs:90:73
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

I don't have an idea yet to solve it...

could you please share full log?

sirkonst commented 1 year ago

Here is full log - edgedb.build.log

scotttrinh commented 1 year ago

@sirkonst

We recently added a git submodule with shared tests, and the latest CLI builds relevant tests programmatically in the cargo build phase, but we need fetchSubmodules = true in the fetchFromGitHub.

Tested locally, and this works:

      edgedb-dev = pkgs.edgedb.overrideAttrs (oldAttrs: rec {
        version = "dev";
        src = pkgs.fetchFromGitHub {
          owner = "edgedb";
          repo = "edgedb-cli";
          rev = "d50d0764805f34fe1b0c1db0c11254c6b97ada04";
          sha256 = "sha256-k4S8BvdecSqyUIHjt9OAy9/nAEdq5ZGpd5U4SWUtEj0=";
          fetchSubmodules = true;
        };
        cargoDeps = pkgs.rustPlatform.importCargoLock {
          lockFile = src + "/Cargo.lock";
          outputHashes = {
            "edgedb-derive-0.5.0" = "sha256-y/mN0XuJtQBtkLmbk2s7hK5joGEH5Ge6sLCD88WyL9o=";
            "edgeql-parser-0.1.0" = "sha256-Y3gXxPuR7qnTL4fu2nZIa3e20YV1fLvm2jHAng+Ke2Q=";
            "rexpect-0.5.0" = "sha256-vstAL/fJWWx7WbmRxNItKpzvgGF3SvJDs5isq9ym/OA=";
            "rustyline-8.0.0" = "sha256-CrICwQbHPzS4QdVIEHxt2euX+g+0pFYe84NfMp1daEc=";
            "serde_str-1.0.0" = "sha256-CMBh5lxdQb2085y0jc/DrV6B8iiXvVO2aoZH/lFFjak=";
            "indexmap-2.0.0-pre" = "sha256-QMOmoUHE1F/sp+NeDpgRGqqacWLHWG02YgZc5vAdXZY=";
          };
        };
      });
sirkonst commented 1 year ago

Already in master - https://github.com/NixOS/nixpkgs/pull/245266