angryzor
commented
1 year ago Ok, I took some time to look at this myself and it seems to be multiple problems:
The new version of the guest additions starts the resizing service as VBoxClient --vmsvga-session, a new service that relies on a kernel module called vmwgfx. This kernel module shows errors on my machine. I'm currently not sure if they are relevant:
May 28 08:42:48 devbox kernel: [drm:vmw_msg_ioctl [vmwgfx]] *ERROR* Failed to open channel.
May 28 08:42:48 devbox kernel: [drm:vmw_msg_ioctl [vmwgfx]] *ERROR* Failed to open channel.Aside from that, VBoxClient --vmsvga-session first tries to connect to this kernel module using IPC, fails, then falls back to VBoxClient --vmsvga using a fork, and fails that as well:
17:03:10.957034 main VBoxClient 7.0.8 r156879 (verbosity: 4) linux.amd64 (Apr 17 2023 18:38:34) release log
17:03:10.957035 main Log opened 2023-07-20T17:03:10.957031000Z
17:03:10.957138 main OS Product: Linux
17:03:10.957168 main OS Release: 6.1.37
17:03:10.957195 main OS Version: #1-NixOS SMP PREEMPT_DYNAMIC Sat Jul 1 11:16:27 UTC 2023
17:03:10.957220 main Executable: /nix/store/53d62dqgh899r0lwrr34qh8pvmnqp1g2-VirtualBox-GuestAdditions-7.0.8-6.1.37/bin/VBoxClient
17:03:10.957221 main Process ID: 1659
17:03:10.957221 main Package type: LINUX_64BITS_GENERIC
17:03:10.957289 main VBoxClient 7.0.8 r156879 started. Verbose level = 4. Wayland environment detected: no
17:03:10.957315 main Service: VMSVGA display assistant
17:03:10.959266 main Initializing service ...
17:03:10.959286 main VBoxClient VMSVGA: probing Desktop Environment helper 'GNOME3'
17:03:10.959292 main VBoxClient VMSVGA: probing Desktop Environment helper 'GENERIC'
17:03:10.959633 dcm-task VBoxClient VMSVGA: vbcl_hlp_generic_display_change_event_monitor_worker started
17:03:10.960153 main VBoxClient VMSVGA: attempt to start display change monitor thread, rc=VINF_SUCCESS
17:03:10.960163 main VBoxClient VMSVGA: using Desktop Environment specific display helper 'GENERIC'
17:03:10.960181 main VBoxClient VMSVGA: Error: unable to connect to IPC server, rc=VERR_FILE_NOT_FOUND
17:03:10.960258 dcm-task VBoxClient VMSVGA: vbcl_hlp_generic_display_change_event_monitor_worker ended
17:03:10.960268 main VBoxClient VMSVGA: helper service terminated, rc=VINF_SUCCESS
17:03:10.960280 main VBoxClient VMSVGA: starting legacy service, rc=VERR_FILE_NOT_FOUND
17:03:10.960283 main VBoxClient VMSVGA: Service is not availabe, skipping
17:03:10.960329 main VBoxClient VMSVGA: End of log file - Log started 2023-07-20T17:03:10.957031000ZThe reason for the first failure is that it is trying to access a socket through an absolute path that doesn't exist:
/** Local IPC name prefix for portable names. */
#define RTLOCALIPC_POSIX_NAME_PREFIX "/tmp/.iprt-localipc-"
static int rtLocalIpcPosixConstructName(struct sockaddr_un *pAddr, uint8_t *pcbAddr, const char *pszName, bool fNative)
{
const char *pszNativeName;
int rc = rtPathToNative(&pszNativeName, pszName, NULL /*pszBasePath not support*/);
if (RT_SUCCESS(rc))
{
size_t cchNativeName = strlen(pszNativeName);
size_t cbFull = !fNative ? cchNativeName + sizeof(RTLOCALIPC_POSIX_NAME_PREFIX) : cchNativeName + 1;
if (cbFull <= sizeof(pAddr->sun_path))
{
RT_ZERO(*pAddr);
#ifdef RT_OS_OS2 /* Size must be exactly right on OS/2. */
*pcbAddr = sizeof(*pAddr);
#else
*pcbAddr = RT_UOFFSETOF(struct sockaddr_un, sun_path) + (uint8_t)cbFull;
#endif
#ifdef HAVE_SUN_LEN_MEMBER
pAddr->sun_len = *pcbAddr;
#endif
pAddr->sun_family = AF_LOCAL;
if (!fNative)
{
memcpy(pAddr->sun_path, RTLOCALIPC_POSIX_NAME_PREFIX, sizeof(RTLOCALIPC_POSIX_NAME_PREFIX) - 1);
memcpy(&pAddr->sun_path[sizeof(RTLOCALIPC_POSIX_NAME_PREFIX) - 1], pszNativeName, cchNativeName + 1);
}
else
memcpy(pAddr->sun_path, pszNativeName, cchNativeName + 1);
}
else
rc = VERR_FILENAME_TOO_LONG;
rtPathFreeNative(pszNativeName, pszName);
}
return rc;
}The reason for the failure in the fallback is similar. It is trying to run /usr/bin/VBoxClient --vmsvga:
/** Defines the DRM client executable (image). */
# define VBOX_DRMCLIENT_EXECUTABLE "/usr/bin/VBoxDRMClient"
# define VBOX_DRMCLIENT_LEGACY_EXECUTABLE "/usr/bin/VBoxClient"
/** Defines the guest property that defines if the DRM resizing client needs to be active or not. */
# define VBOX_DRMCLIENT_GUEST_PROP_RESIZE "/VirtualBox/GuestAdd/DRMResize"
VBGLR3DECL(int) VbglR3DrmLegacyClientStart(void)
{
#if defined(RT_OS_LINUX)
const char *apszArgs[3] = { VBOX_DRMCLIENT_LEGACY_EXECUTABLE, "--vmsvga", NULL };
return VbglR3DrmStart(VBOX_DRMCLIENT_LEGACY_EXECUTABLE, apszArgs);
#else
return VERR_NOT_SUPPORTED;
#endif
}which also doesn't exist on NixOS.
These absolute paths are not patched up by the derivation:
[nix-shell:~]$ strings $(which VBoxClient) | grep /usr
/usr/X11/bin/xrandr
/usr/bin/VBoxClient
/usr/bin/VBoxDRMClient
/usr/lib/pam.d/
/usr/bin:/bin:/usr/sbin:/sbin
/usr/bin:/bin
/usr/bin
/usr/local/bin
ChanceHarrison
puterboy
kjeremy
AnhQuanTrl
C0RD
dlouwers
Yarny0
FriedrichAltheide
dsharp-pivotal
nebulorum
K900
Describe the bug
Before a recent update of my system (running VirtualBox Guest Additions 6.1.40 r154048), guest screen resizing worked using the VMSVGA video adapter. A recent update of NixOS updates the Guest Additions to 7.0.8 r156879 and now this feature is no longer working properly.
Steps To Reproduce
virtualisation.virtualbox.guest.enable = true;.Expected behavior
Guest screen should resize to fill window.
Additional context
Relevant diff of the VBox log between the 2 NixOS generations:
Note the line
VMSVGA DRM resizing client not started, rc=VERR_FILE_NOT_FOUNDI found out that
VBoxClient --vmsvgais not running (psoutput):Manually running
/nix/store/53d62dqgh899r0lwrr34qh8pvmnqp1g2-VirtualBox-GuestAdditions-7.0.8-6.1.37/bin/VBoxClient --vmsvgafixes the problem for the current session.Notify maintainers
@K900 , @erdnaxe
Metadata
Please run
nix-shell -p nix-info --run "nix-info -m"and paste the result.