NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.31k stars 14.28k forks source link

Build failure: nvfetcher #249962

Closed amarshall closed 1 year ago

amarshall commented 1 year ago

Steps To Reproduce

Steps to reproduce the behavior:

  1. NIXPKGS_ALLOW_BROKEN=1 nix-build -A nvfetcher

Build log

Relevant bits:

       > Error: Setup: Encountered missing or private dependencies:
       > aeson >=1.5.6 && <2.1

Additional context

Marked broken in 72573db36b51713115046b1831873b9da583017c.

Notify maintainers

@berberman

Metadata

https://hydra.nixos.org/build/231635785

berberman commented 1 year ago

I just made a new release that should compile: https://hackage.haskell.org/package/nvfetcher-0.6.2.0

amarshall commented 1 year ago

Thanks! Though unfortunately now get a different dep issue:

Error: Setup: Encountered missing or private dependencies:
toml-reader >=0.2 && <0.3
With this nixpkgs diff ```diff diff --git a/pkgs/development/haskell-modules/hackage-packages.nix b/pkgs/development/haskell-modules/hackage-packages.nix index 3d7bcf49a143..c2e58ca5b662 100644 --- a/pkgs/development/haskell-modules/hackage-packages.nix +++ b/pkgs/development/haskell-modules/hackage-packages.nix @@ -210686,8 +210686,8 @@ self: { }: mkDerivation { pname = "nvfetcher"; - version = "0.6.1.0"; - sha256 = "1899x279x236h71infk6h6cxw6sckhzh2z15frq92wpl6viq9qwz"; + version = "0.6.2.0"; + sha256 = "sha256-eODngIytJ3CzdeToI4/QI2y/vv2xsL7qazqtl6qy61E="; isLibrary = true; isExecutable = true; libraryHaskellDepends = [ @@ -210715,7 +210715,6 @@ self: { hydraPlatforms = lib.platforms.none; mainProgram = "nvfetcher"; maintainers = [ lib.maintainers.berberman ]; - broken = true; }) {}; "nvim-hs" = callPackage ```

(Update) I just needed to add toml-reader as a dep and now it works.

GaetanLepage commented 1 year ago

Thanks for fixing @amarshall ! Have you made a PR to ship the fix upstream ?

amarshall commented 1 year ago

@GaetanLepage I haven’t fixed anything. There is already a fix upstream (see above by berberman). No update in nixpkgs yet, and I’m not familiar enough with haskellPackages to know how to properly update just one package (I only see docs about updating all of them), I just hacked on the autogenerated file for testing.

GaetanLepage commented 1 year ago

@GaetanLepage I haven’t fixed anything. There is already a fix upstream (see above by berberman). No update in nixpkgs yet, and I’m not familiar enough with haskellPackages to know how to properly update just one package (I only see docs about updating all of them), I just hacked on the autogenerated file for testing.

Ok makes sense ! Let's wait for the update then :)

bestlem commented 1 year ago

Any progress on this?

teutat3s commented 1 year ago

I guess you can follow https://github.com/NixOS/nixpkgs/pull/249708 for updates.

amarshall commented 1 year ago

Until that’s merged, here’s a nixpkgs patch that I’ve been using.

patch ```diff diff --git a/pkgs/development/haskell-modules/hackage-packages.nix b/pkgs/development/haskell-modules/hackage-packages.nix index 3d7bcf49a143..70fa97104f13 100644 --- a/pkgs/development/haskell-modules/hackage-packages.nix +++ b/pkgs/development/haskell-modules/hackage-packages.nix @@ -210681,33 +210681,33 @@ self: { , binary-instances, bytestring, containers, data-default, extra , free, hspec, hspec-discover, microlens, microlens-th , neat-interpolation, optparse-simple, parsec, prettyprinter - , regex-tdfa, shake, stm, text, tomland, transformers, unliftio + , regex-tdfa, shake, stm, text, toml-reader, transformers, unliftio , unordered-containers, validation-selective }: mkDerivation { pname = "nvfetcher"; - version = "0.6.1.0"; - sha256 = "1899x279x236h71infk6h6cxw6sckhzh2z15frq92wpl6viq9qwz"; + version = "0.6.2.0"; + sha256 = "sha256-eODngIytJ3CzdeToI4/QI2y/vv2xsL7qazqtl6qy61E="; isLibrary = true; isExecutable = true; libraryHaskellDepends = [ aeson aeson-pretty base binary binary-instances bytestring containers data-default extra free microlens microlens-th neat-interpolation optparse-simple parsec prettyprinter regex-tdfa - shake text tomland transformers unordered-containers + shake text toml-reader transformers unordered-containers ]; executableHaskellDepends = [ aeson aeson-pretty base binary binary-instances bytestring containers data-default extra free microlens microlens-th neat-interpolation optparse-simple parsec prettyprinter regex-tdfa - shake text tomland transformers unordered-containers + shake text toml-reader transformers unordered-containers validation-selective ]; testHaskellDepends = [ aeson aeson-pretty async base binary binary-instances bytestring containers data-default extra free hspec microlens microlens-th neat-interpolation optparse-simple parsec prettyprinter regex-tdfa - shake stm text tomland transformers unliftio unordered-containers + shake stm text toml-reader transformers unliftio unordered-containers ]; testToolDepends = [ hspec-discover ]; description = "Generate nix sources expr for the latest version of packages"; @@ -210715,7 +210715,6 @@ self: { hydraPlatforms = lib.platforms.none; mainProgram = "nvfetcher"; maintainers = [ lib.maintainers.berberman ]; - broken = true; }) {}; "nvim-hs" = callPackage ```
cdepillabout commented 1 year ago

Just a heads up, https://github.com/NixOS/nixpkgs/pull/249708 won't contain nvfetcher-0.6.2.0. That update should happen in the next haskell-updates PR.

Also, if anyone watching this thread is interested in always keeping nvfetcher working, please add yourself as a maintainer! (Feel free to ask if you can't figure out how to do this)

chayleaf commented 1 year ago

I suppose this should be solved by #255037

cdepillabout commented 1 year ago

I've marked nvfetcher as non-broken in 4fec13e83269, which is included in https://github.com/NixOS/nixpkgs/pull/255037.

chayleaf commented 1 year ago

this isn't merged yet though