search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.59k stars 13.74k forks source link

Quicklisp Packaging: ql-to-nix.lisp generates invalid attribute names #25074

Open ahmedtd opened 7 years ago

ahmedtd commented 7 years ago

Some autogenerated quicklisp packages have invalid attribute names (according to nix commit b0cb11722626e906a73f10dd9a0c9eea29faf43a). Basically, attribute names must validate according to this regex: [A-Za-z_][A-Za-z0-9-_+]*.

I have worked up a patch for ql-to-nix.lisp that should fix the issue, but I can't figure out how it's meant to be run.

@7c6f434c, since it looks like he wrote this system.

mmahut commented 5 years ago

Any news on this issue?

7c6f434c commented 5 years ago

I think the regexp in the issue is still too permissive (we also escape + as _plus_ now); but apparently the attribute names are now safe.

stale[bot] commented 4 years ago

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.