Closed amarshall closed 1 year ago
It is a known issue from staging fallout. I am on vacations though, so I hope other maintainers will be able to take a look.
It is suspected to be buried in the file binary upgrade.
Le mar. 29 août 2023 à 00:57, Andrew Marshall @.***> a écrit :
Steps To Reproduce
Steps to reproduce the behavior:
- nix-build -A diffoscope (on x86_64-linux, at least)
Build log
=================================== FAILURES =================================== _____ test_nested_symlink __
nested_differences = [<Difference file list -- file list []>, <Difference filetype from file(1) -- filetype from file(1) []>, <Difference dir/link -- dir/link []>, <Difference dir/text -- dir/text []>]
@skip_unless_tools_exist("cpio") @skip_unless_tool_is_at_least("dumpimage", dumpimage_version, "2021.01") @skip_unless_tools_exist("fdtdump") def test_nested_symlink(nested_differences):
assert nested_differences[1].source1 == "dir/link"
E AssertionError: assert 'filetype from file(1)' == 'dir/link' E - dir/link E + filetype from file(1)
tests/comparators/testfit.py:128: AssertionError ____ test_nested_compressedfiles ____
nested_differences = [<Difference file list -- file list []>, <Difference filetype from file(1) -- filetype from file(1) []>, <Difference dir/link -- dir/link []>, <Difference dir/text -- dir/text []>]
@skip_unless_tools_exist("cpio") @skip_unless_tool_is_at_least("dumpimage", dumpimage_version, "2021.01") @skip_unless_tools_exist("fdtdump") def test_nested_compressed_files(nested_differences):
assert nested_differences[2].source1 == "dir/text"
E AssertionError: assert 'dir/link' == 'dir/text' E - dir/text E + dir/link
Additional context
https://hydra.nixos.org/build/232823318 Notify maintainers
@dezgeg https://github.com/dezgeg @danielfullmer https://github.com/danielfullmer @RaitoBezarius https://github.com/RaitoBezarius Metadata
n/a, see Hydra.
— Reply to this email directly, view it on GitHub https://github.com/NixOS/nixpkgs/issues/252045, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACMZRAMM6P3DND5ZHYGYGTXXUH3FANCNFSM6AAAAAA4CAWGFA . You are receiving this because you were mentioned.Message ID: @.***>
Supposedly upstream fixed for file 5.45+ (see issue), and that change is in the version currently in nixpkgs. Reverting file to 5.44 (only for the param to diffoscope itself, not globally) yields the same failure.
It seems they did in test_cpio.py and test_uimage.py but missed the ones in tests/comparators/test_fit.py. It should be easy to fix following that same pattern.
Thanks! I hit this and tracked it down to the staging-next
merge in f900e733c1602b4c46064a9ef0514bb2345a8949.
I see the fix hit nixos-unstable-small
today and it works for me. :+1:
Looks like the latest coreboot upgrade in #251110 broke it again
$ git bisect log
# bad: [4a76638020344ae8a9f061856431182179ab0d28] Merge pull request #253561 from kashw2/juce
# good: [db9208ab987cdeeedf78ad9b4cf3c55f5ebd269b] Merge pull request #254017 from cyber-murmel/klipper-cross
git bisect start '--first-parent' '4a76638020344ae8a9f061856431182179ab0d28' 'db9208ab987cdeeedf78ad9b4cf3c55f5ebd269b'
# good: [b37283985bf2d755aeb3ddba399021f65b68758b] jujutsu: 0.8.0 -> 0.9.0
git bisect good b37283985bf2d755aeb3ddba399021f65b68758b
# good: [e167fca5dd447201af3b27c11a95586af90a45d1] Merge pull request #254092 from fabaff/pymodbus-bump
git bisect good e167fca5dd447201af3b27c11a95586af90a45d1
# good: [211a86d6c3b595d4f43e60be077599130f3053a8] Merge pull request #253891 from r-ryantm/auto-update/python310Packages.transmission-rpc
git bisect good 211a86d6c3b595d4f43e60be077599130f3053a8
# bad: [8fefdd4a1a4aea963bb89593125718ddf82e083d] Merge pull request #254127 from r-ryantm/auto-update/tageditor
git bisect bad 8fefdd4a1a4aea963bb89593125718ddf82e083d
# good: [2caef90449f6b10e8f169ef2b41f619c80383824] Merge pull request #254106 from 999eagle/update/openssl
git bisect good 2caef90449f6b10e8f169ef2b41f619c80383824
# good: [cb87184c7e32880ca8a20b59a58956cfc3391602] Merge pull request #254177 from r-ryantm/auto-update/igv
git bisect good cb87184c7e32880ca8a20b59a58956cfc3391602
# bad: [be6408699e598ea127c6a1a6da74ed27e95b819d] Merge pull request #251110 from jmbaur/coreboot-utils-update
git bisect bad be6408699e598ea127c6a1a6da74ed27e95b819d
# first bad commit: [be6408699e598ea127c6a1a6da74ed27e95b819d] Merge pull request #251110 from jmbaur/coreboot-utils-update
Filed https://github.com/NixOS/nixpkgs/issues/256896 for the new issue since it's unrelated other than that the diffoscope tests are failing again.
Steps To Reproduce
Steps to reproduce the behavior:
nix-build -A diffoscope
(on x86_64-linux, at least)Build log
Additional context
https://hydra.nixos.org/build/232823318. Reproduced on latest master (efed6046cf64a6c64d0f62ff38840a238e882adc).
Notify maintainers
@dezgeg @danielfullmer @RaitoBezarius
Metadata
n/a, see Hydra.