Collision between flutter's and xmlformat's LICENSE file

[gepbird]

Describe the bug

When installing both xmlformat and flutter, I get a warning about a colliding LICENSE file.

Steps To Reproduce

Steps to reproduce the behavior:

1. Add flutter and xmlformat to the packages
2. Rebuild the system
3. Watch it throw a warning about a colliding LICENSE file

Expected behavior

No warnings/errors

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Error line:

error: collision between `/nix/store/9gvw46bp813wg24ydl85swia0l6f6llj-xmlformat-1.04/LICENSE' and `/nix/store/kynlkmw6w70l7i1m6wxrrqzjsxm9jha7-flutter-wrapped-sdk-links/LICENSE'

Notify maintainers

xmlformat: @grahamc flutter: @gilice @lukegb

Metadata

~ ❯ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.49, NixOS, 23.11 (Tapir), 23.11pre522946.0bffda19b8af`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.17.0`
 - channels(root): `"nixos-unstable"`
 - nixpkgs: `/home/gep/.nix-defexpr/channels/nixpkgs`

[gilice]

I cannot reproduce with this:

# flake.nix
{
  inputs.nixpkgs.url = "github:NixOS/nixpkgs/nixpkgs-unstable";
  outputs = { self, nixpkgs }: {
    nixosConfigurations.config = nixpkgs.lib.nixosSystem {
      system = "x86_64-linux";
      modules = [
        {
          # needed to satisfy assertions
          imports = [ /etc/nixos/hardware-configuration.nix ];
          boot.loader.grub.devices = [ "/again/just/so/it/doesnt/error/out" ];
          environment.systemPackages =
            with nixpkgs.legacyPackages."x86_64-linux"; [ xmlformat flutter ];
        }
      ];
    };
  };
}

nixos-rebuild build --flake ./flake.nix#config --impure -v

Please post the relevant part of your config.

[gepbird]

@gilice Looks like this bug only occurs when these packages are defined with home-manager:

home-manager.users.myuser.home.packages = with pkgs;  [
  flutter
  xmlformat
];

[gilice]

Can replicate now. Home-Manager throws an error instead of a warning on collisions. Also happens with flutter dart.

[gilice]

So now there is two questions:

• why does HM treat this warning as an error?
• why does the environment builder try to merge these files, even though they aren't in one of the special dirs (bin, lib, etc?)

[gilice]

Small progress update:

• erroring is the correct thing to do. nixos builds the env with ignoreCollisions = true.
• the correct thing to do would be to move these files to $out/share/doc/<package name>/

[gepbird]

There are (at least) 14 other packages suffering from this type of issue:

• dart (couldn't find LICENSE install part)
• flutter (couldn't find LICENSE install part)
• half https://github.com/NixOS/nixpkgs/blob/98c1a15267f06cbc0bcb95f8ffe8327db78cff0c/pkgs/development/libraries/half/default.nix#L16
• ldc-bootstrap (is this package alive? there are no references for it in top-level and similar) https://github.com/NixOS/nixpkgs/blob/98c1a15267f06cbc0bcb95f8ffe8327db78cff0c/pkgs/development/compilers/ldc/binary.nix#L32
• quantumminigolf https://github.com/NixOS/nixpkgs/blob/98c1a15267f06cbc0bcb95f8ffe8327db78cff0c/pkgs/games/quantumminigolf/default.nix#L27
• vassal https://github.com/NixOS/nixpkgs/blob/98c1a15267f06cbc0bcb95f8ffe8327db78cff0c/pkgs/games/vassal/default.nix#L33
• sgx-sdk https://github.com/NixOS/nixpkgs/blob/98c1a15267f06cbc0bcb95f8ffe8327db78cff0c/pkgs/os-specific/linux/sgx/sdk/default.nix#L172
• ivsc-firmware https://github.com/NixOS/nixpkgs/blob/98c1a15267f06cbc0bcb95f8ffe8327db78cff0c/pkgs/os-specific/linux/firmware/ivsc-firmware/default.nix#L24
• ipu camera bin https://github.com/NixOS/nixpkgs/blob/98c1a15267f06cbc0bcb95f8ffe8327db78cff0c/pkgs/os-specific/linux/firmware/ipu6-camera-bins/default.nix#L43
• peertube https://github.com/NixOS/nixpkgs/blob/98c1a15267f06cbc0bcb95f8ffe8327db78cff0c/pkgs/servers/peertube/default.nix#L127
• libtensorflow-photoprism https://github.com/NixOS/nixpkgs/blob/98c1a15267f06cbc0bcb95f8ffe8327db78cff0c/pkgs/servers/photoprism/libtensorflow.nix#L79
• blobs.gg https://github.com/NixOS/nixpkgs/blob/98c1a15267f06cbc0bcb95f8ffe8327db78cff0c/pkgs/servers/akkoma/emoji/blobs_gg.nix#L23
• documentation-highlighter https://github.com/NixOS/nixpkgs/blob/98c1a15267f06cbc0bcb95f8ffe8327db78cff0c/pkgs/misc/documentation-highlighter/update.sh#L36
• picoloop https://github.com/NixOS/nixpkgs/blob/98c1a15267f06cbc0bcb95f8ffe8327db78cff0c/pkgs/applications/audio/picoloop/default.nix#L41

I'm not planning to fix any of these, since I'd rather not break packages I don't use, anyone feel free to contribute :)

[felschr]

yubioath-flutter is also affected.

[I-Want-ToBelieve]

rustdesk-flutter is also affected.

[I-Want-ToBelieve]

localsend is also affected.