NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.38k stars 13.61k forks source link

neil: Clojure tools not yet in expected location #258132

Closed sg-qwt closed 11 months ago

sg-qwt commented 11 months ago
> neil 
Clojure tools not yet in expected location: /nix/store/7hg59lbjp73hwcsainb5184c5m4jqq23-babashka-1.3.181/clojure_tools/clojure-tools-1.11.1.1347.jar
Downloading https://download.clojure.org/install/clojure-tools-1.11.1.1347.zip to /nix/store/7hg59lbjp73hwcsainb5184c5m4jqq23-babashka-1.3.181/clojure_tools/tools.zip
:borkdude.deps/direct-download /nix/store/7hg59lbjp73hwcsainb5184c5m4jqq23-babashka-1.3.181/clojure_tools/tools.zip (Read-only file system)
----- Error --------------------------------------------------------------------
Type:     java.lang.Exception
Message:  Error: Cannot download Clojure tools. Please download manually from https://download.clojure.org/install/clojure-tools-1.11.1.1347.zip to /nix/store/7hg59lbjp73hwcsainb5184c5m4jqq23-babashka-1.3.181/clojure_tools/tools.zip
Location: /nix/store/m160d7av2rxy8ac6n6ji0ijz75dmq1rf-neil-0.1.55/bin/.neil-wrapped:8:1

----- Context ------------------------------------------------------------------
 4: ;; DO NOT EDIT DIRECTLY. GENERATED FROM scr/babashka/neil.clj
 5: 
 6: (require '[babashka.deps :as deps])
 7: 
 8: (deps/add-deps '{:deps {borkdude/rewrite-edn {:mvn/version "0.2.0"}
    ^--- Error: Cannot download Clojure tools. Please download manually from https://download.clojure.org/install/clojure-tools-1.11.1.1347.zip to /nix/store/7hg59lbjp73hwcsainb5184c5m4jqq23-babashka-1.3.181/clojure_tools/tools.zip
 9:                         org.babashka/spec.alpha {:git/url "https://github.com/babashka/spec.alpha"
10:                                                  :git/sha "1a841c4cc1d4f6dab7505a98ed2d532dd9d56b78"}
11:                         io.github.seancorfield/deps-new {:git/tag "v0.4.13" :git/sha "879c4eb"}
12:                         org.babashka/cli
13:                         #_{:local/root "/Users/borkdude/dev/cli"}

----- Stack trace --------------------------------------------------------------
babashka.impl.deps/add-deps/fn--27052           - <built-in>
borkdude.deps/clojure-tools-install!            - <built-in>
borkdude.deps/-main/fn--5991                    - <built-in>
borkdude.deps/-main                             - <built-in>
clojure.core/apply                              - <built-in>
... (run with --debug to see elided elements)
clojure.core/apply                              - <built-in>
clojure.core/with-bindings*                     - <built-in>
babashka.impl.deps/add-deps/fn--27055           - <built-in>
babashka.impl.deps/add-deps                     - <built-in>
user                                            - /nix/store/m160d7av2rxy8ac6n6ji0ijz75dmq1rf-neil-0.1.55/bin/.neil-wrapped:8:1

Looks like neil is trying to fetch newer cljoure_tools from internet?

cc @jlesquembre

jlesquembre commented 11 months ago

I think https://github.com/NixOS/nixpkgs/pull/257473 should fix it

sg-qwt commented 11 months ago

https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/development/tools/neil/default.nix#L26

@jlesquembre Should L26 be changed to babashka-unwrapped? Looks like babashka-unwrapped is not affected by this bug?

jlesquembre commented 11 months ago

@sg-qwt Looking again to your stacktrace, I think that issue has been fixed in https://github.com/NixOS/nixpkgs/pull/253100, I can run neil with nix run github:NixOS/nixpkgs/nixos-unstable#neil.

Could you try to update you nixpkgs version? If you can't (or don't want to ), you could override the babashka version, with something like pkgs.neil.override {babashka = pkgs.babashka-unwrapped;} see https://nixos.org/manual/nixpkgs/stable/#sec-pkg-override

sg-qwt commented 11 months ago

Yep, its fixed by https://github.com/NixOS/nixpkgs/pull/253100. Haven't updated nixpkgs for some time. Thanks for your tips btw.