turbovnc: window manager option doesn't work

Describe the bug

When calling turbovnc with a window manager name, it will always start with TWM, regardless of the name provided.

Steps To Reproduce

Steps to reproduce the behavior:

install icewm or put it in the path
start turbovnc vncserver -wm icewm
connect client to vnc session

Expected behavior

The window manager used should be the one specified in the configuration or through the command line.

Screenshots

desktop session

Additional context

The problem stems from the default startup script looking in /usr/share/xsessions/ for .desktop files in the format $wm-session.desktop. -wm can be passed a path to a .desktop file, but the default startup script promptly extracts the session name from the path and searches in /usr/share/xsessions/.

This applies to other VNC solutions as well.

A workaround is documented in the wiki by using -xstartup.

Notify maintainers

@nh2

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.133+, Ubuntu, 20.04.6 LTS (Focal Fossa), nobuild`
 - multi-user?: `no`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - nixpkgs: `/home/user/.nix-defexpr/channels/nixpkgs`

NixOS / nixpkgs