nixos gocd-agent module uses wrong bootstrap jar path in startup script

sgonzalezoyuela commented 10 months ago

Describe the bug

When defining a gocd-agent service in Nixos, the service fails to start because the -jar option passed to the java command refers to {store-path}/go-agent/agent-bootstrapper.jar . The file is actually found in the lib folder inside /go-agent

Steps To Reproduce

Define a gocd-agent service in your Nixos configuration.
Rebuild switch
The service fails to start

Error: Unable to access jarfile /nix/store/ddlhmlsn4l2h8gcajsfcfq0mrslgi480-gocd-agent-23.1.0/go-agent/agent-bootstrapper.jar

Expected behavior

The service should start correctly

Screenshots

nov 14 19:15:54 emcb gocd-agent-start[1792]: Error: Unable to access jarfile /nix/store/ddlhmlsn4l2h8gcajsfcfq0mrslgi480-gocd-agent-23.1.0/go-agent/agent-bootstrapper.jar
nov 14 19:15:54 emcb systemd[1]: gocd-agent.service: Main process exited, code=exited, status=1/FAILURE
nov 14 19:15:54 emcb systemd[1]: gocd-agent.service: Failed with result 'exit-code'.

Additional context

Server service scripts includes lib folder and starts without issues.

Notify maintainers

Metadata

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.61, NixOS, 23.05 (Stoat), 23.05.20231105.aeefe20`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.13.6`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

pennae commented 10 months ago

not our module, sorry. only touched the docs.

Scriptkiddi commented 9 months ago

@sgonzalezoyuela why do you think im the maintainer of this module?

sgonzalezoyuela commented 7 months ago

@Scriptkiddi sorry for the confusion, I though you were. I'll remove you from as the maintainer

NixOS / nixpkgs