Use the maintainer type in checkMeta

NixOS / nixpkgs

Nix Packages collection & NixOS

MIT License

17.93k stars 13.95k forks source link

Use the maintainer type in checkMeta #272290

Open Artturin opened 10 months ago

Artturin commented 10 months ago

https://github.com/NixOS/nixpkgs/blob/70475eb9dd8e0a3b7138cf829f96cb404fa1d94b/pkgs/stdenv/generic/check-meta.nix#L310

checkMeta currently uses listOf (attrsOf anything) for maintainers leading to issues like

https://github.com/NixOS/nixpkgs/pull/272199

There is a todo use the maintainer type from lib/tests/maintainer-module.nix

Aleksanaa commented 3 months ago

Found this again. Currently there are tests scattered all over the place related to the properties a maintainer should have. It would be nice if we could merge this into lib.types.maintainer or something, and merge the remaining tests that require networking into another place.