NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.58k stars 13.73k forks source link

xdg-desktop-portal: build failure when `doCheck = false` #275863

Open someplaceguy opened 9 months ago

someplaceguy commented 9 months ago

Steps To Reproduce

When building xdg-desktop-portal with doCheck = false, the build fails with the error Program 'pytest-3 pytest' not found or not executable.

Build log

Log excerpt:

(...)
Program /nix/store/7753941pnr2kii6csvnj445r84rbv92f-glib-2.78.1-dev/bin/gdbus-codegen found: YES (/nix/store/7753941pnr2kii6csvnj445r84rbv92f-glib-2.78.1-dev/bin/gdbus-codegen)
Configuring xdg-document-portal.service using configuration
Configuring org.freedesktop.portal.Documents.service using configuration
Configuring org.freedesktop.impl.portal.PermissionStore.service using configuration
Configuring test.portal using configuration
Configuring limited.portal using configuration
Configuring org.freedesktop.portal.Documents.service using configuration
Configuring org.freedesktop.impl.portal.PermissionStore.service using configuration
Program pytest-3 pytest found: NO

tests/meson.build:268:9: ERROR: Program 'pytest-3 pytest' not found or not executable

A full log can be found at /build/source/build/meson-logs/meson-log.txt

Additional context

This is when trying to build NixOS 23.11. I've disabled the tests locally because the test-portals-inhibit test is failing non-deterministically on my systems (probably due to timing issues?).

Notify maintainers

cc @jtojnar @pks-t @bobby285271


Add a :+1: reaction to issues you find important.

jtojnar commented 9 months ago

Disabling checkPhase removes checkInputs so this is expected.

On Thu, 21 Dec 2023, 17:54 someplaceguy, @.***> wrote:

Steps To Reproduce

When building xdg-desktop-portal with doCheck = false, the build fails with the error Program 'pytest-3 pytest' not found or not executable. Build log

Log excerpt:

(...) Program /nix/store/7753941pnr2kii6csvnj445r84rbv92f-glib-2.78.1-dev/bin/gdbus-codegen found: YES (/nix/store/7753941pnr2kii6csvnj445r84rbv92f-glib-2.78.1-dev/bin/gdbus-codegen) Configuring xdg-document-portal.service using configuration Configuring org.freedesktop.portal.Documents.service using configuration Configuring org.freedesktop.impl.portal.PermissionStore.service using configuration Configuring test.portal using configuration Configuring limited.portal using configuration Configuring org.freedesktop.portal.Documents.service using configuration Configuring org.freedesktop.impl.portal.PermissionStore.service using configuration Program pytest-3 pytest found: NO

tests/meson.build:268:9: ERROR: Program 'pytest-3 pytest' not found or not executable

A full log can be found at /build/source/build/meson-logs/meson-log.txt

Additional context

This is when trying to build NixOS 23.11. Notify maintainers

cc @jtojnar https://github.com/jtojnar @pks-t https://github.com/pks-t @bobby285271 https://github.com/bobby285271

Add a 👍 reaction https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/ to issues you find important https://github.com/NixOS/nixpkgs/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc .

— Reply to this email directly, view it on GitHub https://github.com/NixOS/nixpkgs/issues/275863, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFMEY5GB3N6Z2AS3DBWDZ3YKRSVJAVCNFSM6AAAAABA6VZZR6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2TENZXGE3DENQ . You are receiving this because you were mentioned.Message ID: @.***>

someplaceguy commented 9 months ago

@jtojnar Please see #275867 for a potential fix.