search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.06k stars 14.1k forks source link

Build failure: pkgsMusl.jdk8 #281618

Open superherointj opened 9 months ago

superherointj commented 9 months ago

Steps To Reproduce

  1. nix build .#pkgsMusl.jdk8

Note: openexr error is already fixed in staging. 0b9653816fd556a127b0b9600f7f67cf34de40e5 is cherry-picked.

Build log

/build/source/hotspot/src/share/vm/utilities/globalDefinitions_gcc.hpp:238:39:
 error: ‘isnanf’ was not declared in this scope; did you mean ‘isnan’?
  238 | inline int g_isnan(float  f) { return isnanf(f); }

Log file: pkgsMusl.openjdk.txt

Additional context

No failure in:

So it is something specific to pkgsMusl.jdk8.

Notify maintainers

@edwtjo

Reference

wolfgangwalther commented 7 months ago

This could possibly be fixed with https://git.alpinelinux.org/aports/tree/community/openjdk8/icedtea-hotspot-musl.patch

superherointj commented 7 months ago

@wolfgangwalther Thanks for your report.

Do you want to propose a PR fixing it? On yes, forward it to me for review.

(I'm favoring you posting the PR, so you keep the credit for the fix. I have not tested. In case you are not interested in opening the PR. I may do it. But then, I need someone to review it.)

wolfgangwalther commented 7 months ago

(I'm favoring you posting the PR, so you keep the credit for the fix. I have not tested. In case you are not interested in opening the PR. I may do it. But then, I need someone to review it.)

Feel free to open the PR yourself - I am not actually using jdk.

superherointj commented 7 months ago

After patch. Now errors with:

/build/source/hotspot/agent/src/os/linux/proc_service.h:29:10: fatal error: thread_db.h: No such file or directory

But then, there are more patches here: https://git.alpinelinux.org/aports/tree/community/openjdk8

wolfgangwalther commented 7 months ago

I found #85902, which tried to build jdk8 with pkgsStatic - which is also musl. Might be possible to get some inspiration there.

AndersonTorres commented 3 months ago

Closing from #281618

superherointj commented 3 months ago

The build failure still exist. Are you sure it makes sense to close this?

AndersonTorres commented 3 months ago

Hum, the intention is tracking the fixups? OK then!

superherointj commented 3 months ago

I wish I could transfer these issues for some other account, it messes with my GitHub. I have too many.

AndersonTorres commented 3 months ago

Create a superherointj-nixpkgs org like I did, hihi