search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.67k stars 13.81k forks source link

Package request: `playwright-driver`: package Firefox and Webkit #288826

Closed WesleyAC closed 5 days ago

WesleyAC commented 7 months ago

Project description

playwright-browser currently only packages Chromium. It would be good to also package the versions of Firefox and Webkit that are supported upstream.

cc @phaer @fabaff @pietdevries94 @kalekseev @teto

Add a :+1: reaction to issues you find important.

teto commented 7 months ago

chromium is patchless while firefox had to carry some patch, + additional builds probably so that's a whole other level of commitment. Might be best to just patch with nix-ld (if that's possible) the proposed firefox (or run it in docker ?). Else feel free to takeover https://github.com/NixOS/nixpkgs/pull/197899

WesleyAC commented 7 months ago

Ah, that makes sense. I recall using https://github.com/ludiosarchive/nixos-playwright in the past, so that approach may be applicable.

Do you know if Webkit also requires patches?

nixos-discourse commented 6 months ago

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/playwright-tests-on-multiple-browsers/41309/2

phaer commented 6 months ago

I gave this a try in https://github.com/NixOS/nixpkgs/pull/298944

teto commented 5 days ago

merged the mnentioned PR