NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.67k stars 13.82k forks source link

Update request: standardnotes 3.181.23 → 3.191.4 #293270

Open baalajimaestro opened 7 months ago

baalajimaestro commented 7 months ago

Notify maintainers

@M-Gregoire @chuangzhu @squalus


Note for maintainers: Please tag this issue in your PR.


Add a :+1: reaction to issues you find important.

higherorderfunctor commented 6 months ago

This overlay works for me. Just overriding the version and src breaks without the phase changes due to the spaces in the path during updateAutotoolsGnuConfigScriptsPhase. It appears to split the path here: https://github.com/NixOS/nixpkgs/blob/0f0e60bdd4a31a6ae291943e145a3cc60ffa77cc/pkgs/build-support/setup-hooks/update-autotools-gnu-config-scripts.sh#L7

Also need to pin electron_27 to match the package version set here: https://github.com/standardnotes/app/blob/4b19076f9b549a00c98eca8e1c35ee0d62e05155/packages/desktop/package.json#L46

Edit: my current overlay for standard notes tracking upstream repo using nvfetcher: https://github.com/higherorderfunctor/nixos-config/blob/dotfiles/overlays/standardnotes-overlay.nix

higherorderfunctor commented 3 months ago

You now have to allow electron 27 to be used since it went EOL.

I reported it upstream: https://github.com/standardnotes/forum/issues/3626

      import nixpkgs {
        inherit system;
        overlays = import ./overlays {inherit inputs lib;};
        config = {
          allowUnfree = true;
          permittedInsecurePackages = [
            "electron-27.3.11" # standard notes
          ];
        };
      });