applet-window-buttons: update for KDE 6

dr460nf1r3 commented 8 months ago

Describe the bug

The current version of libsForQt5.applet-window-buttons is made for Qt5 and needs to be updated for usage with KDE 6 since it does not work anymore.

Steps To Reproduce

Steps to reproduce the behavior:

Have applet active
Observe an error message that its not made for KDE 6

Expected behavior

The applet works.

Additional context

There is already a PR to the main repo that fixes the application, Arch uses it to provide this applet for example. I'm using this myself and it works fairly well.
Given the maintainer was inactive for a very long time, it is almost safe to assume that this PR won't be merged.
The patch can be found here.

Notify maintainers

@dotlambda

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

❯ nix-shell -p nix-info --run "nix-info -m"
this path will be fetched (0.00 MiB download, 0.00 MiB unpacked):
/nix/store/w3cx1ir83mgri4ypsix0121v0mykhqk1-nix-info
copying path '/nix/store/w3cx1ir83mgri4ypsix0121v0mykhqk1-nix-info' from 'https://cache.garnix.io'...
- system: `"x86_64-linux"`
- host os: `Linux 6.7.8-2-cachyos, Garuda Linux, noversion, rolling`
- multi-user?: `yes`
- sandbox: `yes`
- version: `nix-env (Nix) 2.19.3`
- channels(root): `"home-manager, nixos"`
- nixpkgs: `/nix/store/8ny3r3jvj17ljzc89h9rpfr56a7nyn8c-source`

Add a :+1: reaction to issues you find important.

K900 commented 7 months ago

Excuse me?

dr460nf1r3 commented 7 months ago

Sorry if this was the wrong thing to do 😅

K900 commented 7 months ago

I am not the maintainer of libsForQt5.applet-window-buttons.

dr460nf1r3 commented 7 months ago

Oh god, you are right 🫠 that's absolutely my bad. Sorry again.

Leptopoda commented 5 months ago

I was able to get it running with:

{ lib, stdenv, fetchgit, cmake, extra-cmake-modules, kcolorscheme, kconfig
, kcoreaddons, kdecoration, ki18n, kirigami, kitemmodels, ksvg, libplasma
, plasma-workspace, qt6 }:

stdenv.mkDerivation rec {
  pname = "applet-window-buttons6";
  version = "0.13.0";

  src = fetchgit {
    #owner = "moodyhunter";
    #repo = "applet-window-buttons";
    url = "https://github.com/moodyhunter/applet-window-buttons6.git";
    rev = "326382805641d340c9902689b549e4488682f553";
    hash = "sha256-POr56g3zqs10tmCbKN+QcF6P6OL84tQNkA+Jtk1LUfY=";
  };

  nativeBuildInputs = [ cmake extra-cmake-modules qt6.wrapQtAppsHook ];

  buildInputs = [
    kcolorscheme
    kconfig
    kcoreaddons
    kdecoration
    ki18n
    kirigami
    kitemmodels
    ksvg
    libplasma
    plasma-workspace
    qt6.qtbase
    qt6.qtdeclarative
  ];

  meta = with lib; {
    description =
      "Plasma 6 applet in order to show window buttons in your panels";
    homepage = "https://github.com/psifidotos/applet-window-buttons";
    license = licenses.gpl2Plus;
    maintainers = with maintainers; [ dotlambda ];
  };
}

Which can later be included like any other package (kdePackages.callPackage ./applet-window-buttons.nix { }). I'm new to nix and not sure if I did everything right (I also had issues using fetchGitHub) but I'll try to upsream this in the coming days.

BBFifield commented 5 months ago

I was able to get it running with:

Which can later be included like any other package (kdePackages.callPackage ./applet-window-buttons.nix { }). I'm new to nix and not sure if I did everything right (I also had issues using fetchGitHub) but I'll try to upsream this in the coming days.

Good stuff! I'm also quite new to nix and appreciate the effort you went through to make this module. It works for me with the exception of it always defaulting to "Always Visible" even when "visibility" is set to anything else in Plasma-Manager with overrideConfig enabled. Likely an issue with plasma-manager, but I'm not 100% sure.

dotlambda commented 5 months ago

Closing because it's unacceptable you assign others who aren't working on the issue.

Leptopoda commented 5 months ago

You are right that it was not ok from op to assign anyone but the issue is still there. Can someone please reopen it?

Leptopoda commented 5 months ago

I was able to get it running with:

Which can later be included like any other package (kdePackages.callPackage ./applet-window-buttons.nix { }). I'm new to nix and not sure if I did everything right (I also had issues using fetchGitHub) but I'll try to upsream this in the coming days.

Good stuff! I'm also quite new to nix and appreciate the effort you went through to make this module. It works for me with the exception of it always defaulting to "Always Visible" even when "visibility" is set to anything else in Plasma-Manager with overrideConfig enabled. Likely an issue with plasma-manager, but I'm not 100% sure.

I too have this issue and hope that I'll get it fixed soon. Once I have more time and everything is working ok I'll make a PR to get it fixed upstream

ShalokShalom commented 5 months ago

@dotlambda The search lists you as the maintainer. Does this mean, this is not up to date anymore?

dotlambda commented 5 months ago

@dotlambda The search lists you as the maintainer. Does this mean, this is not up to date anymore?

It is but that doesn't mean you can expect me to fix every issue with the package. Besides, someone being assigned means they are working on it which I'm not.

ShalokShalom commented 5 months ago

No expectations. ☺️

Leptopoda commented 5 months ago

@dotlambda can you please re open this issue so it is still tracked?

Leptopoda commented 3 months ago

Ok it looks like a new package built directly from the fork has arised: https://github.com/NixOS/nixpkgs/blob/6212d8033f4fa94ac48fd5befca1403babaf1b06/pkgs/kde/third-party/applet-window-buttons6/default.nix

Maybe the old package should just be removed? I have no idea of the process so a friendly ping to the new and old maintainer @A1ca7raz and @dotlambda so we can find a solution.

A1ca7raz commented 3 months ago

Maybe the old package should just be removed?

Unless KDE5 is removed completely from nixpkgs, I think we should keep the old package.

NixOS / nixpkgs