Open gotjoshua opened 6 months ago
I am not a xrdp maintainer
I am not a xrdp maintainer
sorry bout that, i went with the last three commits that touched the file...
found this now https://search.nixos.org/packages?channel=23.11&show=xrdp&from=0&size=50&sort=relevance&type=packages&query=xrdp
Charlotte Van Petegem nixpkgs@cvpetegem.be @chvp are you still an active maintainer?
The section that would need updating is blamed on @lucasew, who is also not a formal maintainer...
I maintain the package, I have not touched the NixOS module yet (and I don't actively use the package anymore).
- the port variable ought to be a string and be used to patch the ini (not passed to the cli)
I agree with that but that would require a bigger rewrite of the module. Right now the overrides are for the config files are created in a complicated way and they should be converted to just freeform settings, probably in an ini format.
Could you open a PR for that? Otherwise I would mark this point as wont-fix.
- then one could just use ini syntax directly like
services.xrdp.port = "tcp://:3389";
please test #315101
- the service should use the /etc/xrdp ini files
Yeah true but that falls under my first comment.
4. by default the service should bind to both ipv4 and 6
is also fixed in my PR
Describe the bug
xrdp only binding to ipv6 and not using port settings from ini as the default port setting is passed via cli and trumps settings from the ini
Steps To Reproduce
Steps to reproduce the behavior:
Expected behavior
services.xrdp.port = "tcp://:3389";
Screenshots
without the systemd ExecStart patch it only binds ipv6
the ini file is used, via the direct nix store path (rather than /etc/xrdp/
Notify maintainers
@nagy @pennae @chvp
Metadata