search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.46k stars 13.66k forks source link

Update request: ALVR 20.6.1 -> 20.8.1 #305232

Open Krutonium opened 5 months ago

Krutonium commented 5 months ago

Notify maintainers @PassiveLemon

Issue I've noticed: They've discontinued the AppImage so we need to build it from scratch :\

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

PassiveLemon commented 5 months ago

ALVR removed the appimage format in version 20.7.1 and above so it will need to be built from source. I've tried to do this and have not been successful but I'll give it another shot.

alisonjenkins commented 2 months ago

ALVR removed the appimage format in version 20.7.1 and above so it will need to be built from source. I've tried to do this and have not been successful but I'll give it another shot.

I have been having a go at this today via an overlay on my nix-configs: https://github.com/alisonjenkins/nix-config/tree/alvr-overlay

I am currently stuck as I cannot seem to get it to find the ffmpeg includes directory.

I am hoping to get this working as an overlay and then submit a PR to get it working as a proper Nix package.

alisonjenkins commented 2 months ago

ALVR removed the appimage format in version 20.7.1 and above so it will need to be built from source. I've tried to do this and have not been successful but I'll give it another shot.

I have been having a go at this today via an overlay on my nix-configs: https://github.com/alisonjenkins/nix-config/tree/alvr-overlay

I am currently stuck as I cannot seem to get it to find the ffmpeg includes directory.

I am hoping to get this working as an overlay and then submit a PR to get it working as a proper Nix package.

So I changed tack to just trying to get the project to compile on NixOS. It appears that the ALVR dev is using cargo xtask to vendor and patch several dependencies including ffmpeg and x264 so I have been trying to get those to compile but am still having issues with getting those dependencies to compile due to missing dependencies of the dependencies.

JonBoyleCoding commented 2 months ago

Just to note that the latest version is now 20.9.1.

JonBoyleCoding commented 2 months ago

Is there something wrong with using the tarballs in their releases instead of building from scratch? I know it would be preferable to build from scratch, but might be a stopgap to ensure the latest version is available.

PassiveLemon commented 2 months ago

I've had success with the tarballs but and I posted a derivation for other contributors to use since I don't plan on maintaining ALVR anymore because I don't use it. Building directly from source is ideal in my opinion but tarballs are still a good solution

JonBoyleCoding commented 2 months ago

Ah - I see there is a PR in draft #308097 - I'll try things out from there.