search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.64k stars 13.8k forks source link

Automate approval badges update through GitHub action #307917

Open Sigmanificient opened 5 months ago

Sigmanificient commented 5 months ago

Issue description

When reviewing new packages or updates, people tend to approve the changes proposed without adding the appropriate labels. Nixpkgs has approvals: 1, approvals: 2, approvals: 3+ and approved-by: package-maintainer but they are still updated, manually by kind volunteers.

I think this process could be entirely automated through a small GitHub action, and I am surprised that it hasn't been yet. In the action doc, there is an example about running a workflow when a pr review is submitted.

I also found this action that counts the number of PR approvals and this post featuring manual scripts.

This would save time and help filter the pull requests to merge them more quickly.

wegank commented 5 months ago

Related: #264633

Sigmanificient commented 5 months ago

Related: #264633

Oh I didn't saw it

Aleksanaa commented 5 months ago

Maybe we can use a separate userbot to do this? Taking up some people's own users may have some side effects (such as wasting the API limit?)