NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
16.59k stars 13.07k forks source link

Missing extra tools for Ark in Plasma 6 #311240

Open Sicheng-Pan opened 2 months ago

Sicheng-Pan commented 2 months ago

Describe the bug

The package definition for kdePackages.ark does not specify the extra tools that can be used by Ark. The older definition libsForQt5.ark contains extra tools such as unar to handle extra types of archives.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Open a rar file with Ark in Plasma 6

Expected behavior

I could configure the extra tools for Ark by overriding package definition

Notify maintainers

@K900

Metadata

 - system: `"x86_64-linux"`
 - host os: `Linux 6.8.9, NixOS, 24.05 (Uakari), 24.05.20240511.062ca2a`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - channels(root): `"nixos"`
 - nixpkgs: `/nix/store/pfc56yr7y3wflvbgnrpscf2n1m4j3xd7-source`

Add a :+1: reaction to issues you find important.

stuebinm commented 2 months ago

Hi! I'm not this package's maintainer; the commit you saw was a tree-wide auto generated change adding the meta.mainProgram attribute to packages where it was missing & trivial to add. I'll unsubscribe from this thread.

Note that the ark package does have maintainers set, they're just not set in the file itself (you can get them by doing e.g. nix-instantiate --eval --strict -A kdePackages.ark in a nixpkgs checkout's root). Alternatively, take a look at the CODEOWNERS file which also has entries for that subdirectory.

K900 commented 2 months ago

Those archive formats should be handled by libarchive.

Sicheng-Pan commented 2 months ago

If I open an rar file with Ark I will receive the following error:

No suitable plugin found. Ark does not seem to support this file type.

Screenshot_20240513_102101

Sicheng-Pan commented 2 months ago

@K900 May I ask if you could read rar or 7z archives with Ark in Plasma 6 only using the libarchive plugin? I know libarchive support rar and 7z, but I'm unsure whether Ark actually use them for these formats.

K900 commented 2 months ago

I've checked the sources and it looks like Ark explicitly doesn't use libarchive for those. I'll ask around and see why that was done.

SuperSamus commented 2 months ago

Support for 7-zip was recently added. https://invent.kde.org/utilities/ark/-/merge_requests/238