NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.07k stars 14.13k forks source link

Update request: openlp 2.4.6 → 3.1.1 #312624

Open matj1 opened 5 months ago

matj1 commented 5 months ago

Notify maintainers

@jorsn
@Stunkymonkey
@mweinelt


Note for maintainers: Please tag this issue in your PR.


Add a :+1: reaction to issues you find important.

jorsn commented 5 months ago

Hi, I will try to port to the new version 3.1.1 at the weekend. However, I don't use OpenLP any more, so I wouldn't mind if someone took over the package.

matj1 commented 5 months ago

I would update it if it is just that I increase the version number and check that it builds. But I don't have any experience with Nix package maintenance, and there is also #296477 seeming independent of version numbers, so I still would rather let you update this because I don't know how to solve #296477.

jorsn commented 5 months ago

I have a working package for 3.1.2 now.

@matj1: Can I add you as a second maintainer? When there is anything nontrivial I can jump in, but I simply won't notice version updates or runtime breakages, if noone creates an issue.

Edit: If you are willing, please create a pull request 'maintainers: add matj1' against my branch https://github.com/jorsn/nixpkgs/tree/openlp, where you add yourself to the global maintainer list and to the package (in pkgs/applications/misc/openlp/lib.nix) as described in the manual.

matj1 commented 5 months ago

Can I add you as a second maintainer?

Unfortunately for this case, I switched from NixOS back to Arch today because too much important stuff didn't work on NixOS. So that I would be a maintainer of a Nix package is not viable (so far, unless I get to using Nix on Arch).