Davis default configuration doesn't typecheck / nginx config can't be disabled

TheConfuZzledDude commented 3 months ago

The default value of the nginx option at https://github.com/NixOS/nixpkgs/blob/57610d2f8f0937f39dbd72251e9614b1561942d8/nixos/modules/services/web-apps/davis.nix#L223 is null, but the type is a submodule. This is means that

It doesn't typecheck without setting nginx to some module
You can't disable its changes to the nginx config easily.

If the intention is to enable it by default, the default value should be set to {}, like in the example configuration, and if the intention is to let it be disabled (by default or not), the type should be changed to nullOr submodule (rest of type)

@Ramblurr

Ramblurr commented 3 months ago

Thanks for reporting this. The intention is for it to be disabled by default. Are you interested in PRing a fix?

TheConfuZzledDude commented 3 months ago

Yep, I'd be happy to, as soon as I can get my own configuration actually working (500 error anywhere except the dashboard and no visible logs anywhere 😅)

Elinvention commented 1 month ago

I also have another issue that I can't debug, because I can't see davis's logs. Can we get some logging?

NixOS / nixpkgs

Davis default configuration doesn't typecheck / nginx config can't be disabled #317303